Skip to content

Commit b8d6f21

Browse files
committed
CR: assert on proper URLs in contact list API tests
AUT-2568
1 parent 0e732ba commit b8d6f21

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

test/unit/Suite/Api/ContactListTest.php

+16-13
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,14 @@ public function createContactList_Perfect_Perfect(): void
2727
$contactIds = [1, 2, 3];
2828
$this->apiClient
2929
->method('post')
30-
->with($this->endPoints->createContactList($this->customerId), [
31-
'name' => $this->listName,
32-
'key_id' => 'id',
33-
'external_ids' => $contactIds,
34-
])
30+
->with(
31+
"api_base_url/$this->customerId/contactlist",
32+
[
33+
'name' => $this->listName,
34+
'key_id' => 'id',
35+
'external_ids' => $contactIds,
36+
]
37+
)
3538
->willReturn($this->apiSuccess(['id' => $this->contactListId]));
3639

3740
$contactListId = $this->listService->createContactList($this->customerId, $this->listName, $contactIds);
@@ -88,7 +91,7 @@ public function getContactLists_Perfect_Perfect(): void
8891

8992
$this->apiClient
9093
->method('get')
91-
->with($this->endPoints->contactLists($this->customerId))
94+
->with("api_base_url/$this->customerId/contactlist")
9295
->willReturn($this->apiSuccess($contactLists));
9396

9497
$returnedContactLists = $this->listService->getContactLists($this->customerId);
@@ -109,7 +112,7 @@ public function findContactListByName_Perfect_Perfect(): void
109112

110113
$this->apiClient
111114
->method('get')
112-
->with($this->endPoints->contactLists($this->customerId))
115+
->with("api_base_url/$this->customerId/contactlist")
113116
->willReturn($this->apiSuccess($contactLists));
114117

115118
$contactListId = $this->listService->findContactListByName($this->customerId, $this->listName);
@@ -178,7 +181,7 @@ public function addToContactList_Perfect_Perfect(): void
178181
->expects($this->once())
179182
->method('post')
180183
->with(
181-
$this->endPoints->addToContactList($this->customerId, $this->contactListId),
184+
"api_base_url/$this->customerId/contactlist/654321/add",
182185
[
183186
'key_id' => 'id',
184187
'external_ids' => $contactIds,
@@ -211,7 +214,7 @@ public function replaceContactList_Perfect_Perfect(): void
211214
$this->apiClient
212215
->method('post')
213216
->with(
214-
$this->endPoints->replaceContactList($this->customerId, $this->contactListId),
217+
"api_base_url/$this->customerId/contactlist/654321/replace",
215218
[
216219
'key_id' => 'id',
217220
'external_ids' => $contactIds,
@@ -239,12 +242,12 @@ public function replaceContactList_ApiFailure_ThrowsException(): void
239242
/**
240243
* @test
241244
*/
242-
public function getContactIdsInList_Perfect_Perfect(): void
245+
public function getContactIdsInList_CalledWithProperUrl_ApiResponseConverted(): void
243246
{
244247
$response = ['value' => [1, 2, 3], 'next' => null];
245248
$this->apiClient
246249
->method('get')
247-
->with($this->endPoints->contactIdsInList($this->customerId, $this->contactListId))
250+
->with("api_base_url/$this->customerId/contactlist/$this->contactListId/contactIds")
248251
->willReturn($this->apiSuccess($response));
249252

250253
$result = $this->listService->getContactIdsInList($this->customerId, $this->contactListId);
@@ -273,7 +276,7 @@ public function getContactsOfList_Perfect_Perfect(): void
273276
$chunk = [1, 2, 3];
274277
$this->apiClient
275278
->method('get')
276-
->with($this->endPoints->contactsOfList($this->customerId, $this->contactListId, $limit, $offset))
279+
->with("api_base_url/$this->customerId/contactlist/654321/contacts/?limit=100&offset=200")
277280
->willReturn($this->apiSuccess($chunk));
278281

279282
$result = $this->listService->getContactsOfList($this->customerId, $this->contactListId, $limit, $offset);
@@ -328,7 +331,7 @@ public function deleteContactsFromList_Perfect_Perfect(): void
328331
->expects($this->once())
329332
->method('post')
330333
->with(
331-
$this->endPoints->deleteContactsFromList($this->customerId, $this->contactListId),
334+
"api_base_url/$this->customerId/contactlist/654321/delete",
332335
[
333336
'key_id' => 'id',
334337
'external_ids' => $contactIds,

0 commit comments

Comments
 (0)