fixing lint issues

Author: gfwilliams

.eslintrc.js

@@ -1,9 +1,12 @@
 module.exports = {
     "extends": "eslint:recommended",
     "globals": {
-      "Utils" : "writable",
+      "Utils" : "writable", // defined in utils.js
       "UART" : "readonly",
-      "Puck" : "readonly"
+      "Puck" : "readonly",
+      "device" : "writable", // defined in index.js
+      "appJSON" : "writable", // defined in index.js
+
     },
     "rules": {
         "indent": [

js/appinfo.js

@@ -76,10 +76,10 @@ function translateJS(options, app, code) {
       }
     } else if (tok.str.startsWith("`")) {
       // it's a tempated String! scan all clauses inside it and re-run on the JS in those
-      var re = /\$\{[^}]*\}/g;
+      let re = /\$\{[^}]*\}/g, match;
       while ((match = re.exec(tokenString)) != null) {
-        var orig = match[0];
-        var replacement = translateJS(options, app, orig.slice(2,-1));
+        let orig = match[0];
+        let replacement = translateJS(options, app, orig.slice(2,-1));
         tokenString = tokenString.substr(0,match.index+2) + replacement + tokenString.substr(match.index + orig.length-1);
       }
     }

js/comms.js

@@ -115,7 +115,7 @@ const Comms = {
   /* when connected, this is the name of the device we're connected to as far as Espruino is concerned
   (eg Bluetooth/USB/Serial1.println("Foo") ) */
   espruinoDevice : undefined,
-// ================================================================================
+  // ================================================================================
   // Show a message on the screen (if available)
   showMessage : (txt) => {
     console.log(`<COMMS> showMessage ${JSON.stringify(txt)}`);

js/index.js

@@ -49,7 +49,7 @@ function appJSONLoadedHandler() {
       });
   });
   let promise = Promise.resolve();
-  if ("undefined" != typeof onAppJSONLoaded)
+  if ("undefined" != typeof onAppJSONLoaded) /*global onAppJSONLoaded*/
     promise = promise.then(onAppJSONLoaded);
   // finally update what we're showing
   promise.then(function() {
@@ -989,12 +989,12 @@ function getAppsToUpdate(options) {
 
 function refreshMyApps() {
   // if we've got a callback, call it first
-  if ("function"==typeof onRefreshMyApps)
+  if ("function"==typeof onRefreshMyApps) /*global onRefreshMyApps*/
     onRefreshMyApps();
   // Now update...
   let panelbody = document.querySelector("#myappscontainer .panel-body");
   let appsToUpdate = getAppsToUpdate(); // this writes canUpdate attributes to apps in device.appsInstalled
-  panelbody.innerHTML = device.appsInstalled.sort(appSorterUpdatesFirst).map(appInstalled => {
+  panelbody.innerHTML = device.appsInstalled.sort(Utils.appSorterUpdatesFirst).map(appInstalled => {
     let app = appNameToApp(appInstalled.id);
     return getAppHTML(app, appInstalled, "myapps");
   }).join("");

js/utils.js

@@ -176,17 +176,17 @@ const CODEPAGE_CONVERSIONS = {
 /// Convert any character that cannot be displayed by Espruino's built in fonts
 /// originally https://github.com/espruino/EspruinoAppLoaderCore/pull/11/files
 function convertStringToISO8859_1(originalStr) {
-  var chars = originalStr.split('');
-  for (var i = 0; i < chars.length; i++) {
-    var ch = chars[i];
+  let chars = originalStr.split('');
+  for (let i = 0; i < chars.length; i++) {
+    let ch = chars[i];
     if (CODEPAGE_CONVERSIONS[ch])
       chars[i] = CODEPAGE_CONVERSIONS[ch];
     else if (chars[i].charCodeAt() > 255) {
       console.log("Skipped conversion of char: '" + chars[i] + "'");
       chars[i] = "?";
     }
   }
-  var translatedStr = chars.join('');
+  let translatedStr = chars.join('');
   if (translatedStr != originalStr)
     console.log("Remapped text: "+originalStr+" -> "+translatedStr);
   return translatedStr;
@@ -281,9 +281,9 @@ function toJSString(s) {
     else if (ch==92) json += "\\\\"; // slash
     else if (ch<32 || ch==127 || ch==173 ||
               ((ch>=0xC2) && (ch<=0xF4))) // unicode start char range
-        json += "\\x"+(ch&255).toString(16).padStart(2,0);
+      json += "\\x"+(ch&255).toString(16).padStart(2,0);
     else if (ch>255)
-        json += "\\u"+(ch&65535).toString(16).padStart(4,0);
+      json += "\\u"+(ch&65535).toString(16).padStart(4,0);
     else json += s[i];
   }
   return json + "\"";
@@ -335,17 +335,17 @@ function searchRelevance(value, searchString) {
       relevance += 5;
   }
   // compare string parts
-  var partRelevance = 0;
-  var valueParts = value.split(/[\s(),.-]/).filter(p=>p.length);
+  let partRelevance = 0;
+  let valueParts = value.split(/[\s(),.-]/).filter(p=>p.length);
   searchString.split(/[\s-(),.-]/).forEach(search=>{
     valueParts.forEach(v=>{
       if (v==search)
-      partRelevance += 20; // if a complete match, +20
+        partRelevance += 20; // if a complete match, +20
       else {
         if (v.includes(search)) // the less of the string matched, lower relevance
-        partRelevance += Math.max(0, 10 - (v.length - search.length));
+          partRelevance += Math.max(0, 10 - (v.length - search.length));
         if (v.startsWith(search))  // add a bit of the string starts with it
-        partRelevance += 10;
+          partRelevance += 10;
       }
     });
   });