Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minification / Rollup improvements #242

Open
gfwilliams opened this issue Aug 5, 2020 · 2 comments
Open

Minification / Rollup improvements #242

gfwilliams opened this issue Aug 5, 2020 · 2 comments

Comments

@gfwilliams
Copy link
Member

Right now the IDE has two options - Esprima and the online closure compiler (which is slow, and rate limited).

@opichals has done some great work getting rollup working with EspruinoTools and the IDE, but I've been really struggling to get this to work reliably on espruino.com/ide. Original PRs here:

#197
espruino/EspruinoTools#80

For basically the last 2 years (since the merge) I've been maintaining a private fork that I build espruino.com/ide and the Web app from because I can't get it working nicely, and I just had another go for a few hours and haven't had success. So rather than waiting until I break something permanently in my fork (and having a public repo that doesn't work), I'm just going to revert the PR for now and open this issue.

I still really want to get this going, but I'll be adding a serverside element to the IDE soon and it might make more sense to implement rollup in that - it seems that realistically I may need to rethink how modules are handled in the IDE in order to get it to integrate nicely.

@opichals
Copy link
Contributor

opichals commented Aug 6, 2020

@gfwilliams Fair enough. The rollup and used plugins need updating anyway from the original PR shape.

I did that work and released that work but didn't get to update the EspruinoTools and browser support yet.

@gfwilliams
Copy link
Member Author

Thanks - I'll have a look into this when I get a moment and will see if I can come up with some kind of system that's flexible enough to integrate cleanly with Rollup.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants