forked from rectorphp/rector
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathNullableCompareToNullRector.php
126 lines (106 loc) · 3.07 KB
/
NullableCompareToNullRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
<?php
declare(strict_types=1);
namespace Rector\CodingStyle\Rector\If_;
use PhpParser\Node;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Stmt\If_;
use PHPStan\Type\ArrayType;
use PHPStan\Type\BooleanType;
use PHPStan\Type\FloatType;
use PHPStan\Type\IntegerType;
use PHPStan\Type\MixedType;
use PHPStan\Type\NullType;
use PHPStan\Type\StringType;
use PHPStan\Type\UnionType;
use Rector\Core\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\If_\NullableCompareToNullRector\NullableCompareToNullRectorTest
*/
final class NullableCompareToNullRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Changes negate of empty comparison of nullable value to explicit === or !== compare',
[
new CodeSample(
<<<'CODE_SAMPLE'
/** @var stdClass|null $value */
if ($value) {
}
if (!$value) {
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
/** @var stdClass|null $value */
if ($value !== null) {
}
if ($value === null) {
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [If_::class];
}
/**
* @param If_ $node
*/
public function refactor(Node $node): ?Node
{
if ($node->cond instanceof BooleanNot && $this->isNullableNonScalarType($node->cond->expr)) {
$node->cond = new Identical($node->cond->expr, $this->nodeFactory->createNull());
return $node;
}
if ($this->isNullableNonScalarType($node->cond)) {
$node->cond = new NotIdentical($node->cond, $this->nodeFactory->createNull());
return $node;
}
return null;
}
private function isNullableNonScalarType(Node $node): bool
{
$staticType = $this->getStaticType($node);
if ($staticType instanceof MixedType) {
return false;
}
if (! $staticType instanceof UnionType) {
return false;
}
// is non-nullable?
if ($staticType->isSuperTypeOf(new NullType())->no()) {
return false;
}
// is array?
foreach ($staticType->getTypes() as $subType) {
if ($subType instanceof ArrayType) {
return false;
}
}
// is string?
if ($staticType->isSuperTypeOf(new StringType())->yes()) {
return false;
}
// is number?
if ($staticType->isSuperTypeOf(new IntegerType())->yes()) {
return false;
}
// is bool?
if ($staticType->isSuperTypeOf(new BooleanType())->yes()) {
return false;
}
return ! $staticType->isSuperTypeOf(new FloatType())
->yes();
}
}