forked from rectorphp/rector
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathWhileEachToForeachRector.php
125 lines (108 loc) · 3.12 KB
/
WhileEachToForeachRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
<?php
declare(strict_types=1);
namespace Rector\Php72\Rector\While_;
use PhpParser\Node;
use PhpParser\Node\Expr\ArrayItem;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\List_;
use PhpParser\Node\Stmt\Foreach_;
use PhpParser\Node\Stmt\While_;
use Rector\Core\NodeManipulator\AssignManipulator;
use Rector\Core\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @source https://wiki.php.net/rfc/deprecations_php_7_2#each
*
* @see \Rector\Tests\Php72\Rector\While_\WhileEachToForeachRector\WhileEachToForeachRectorTest
*/
final class WhileEachToForeachRector extends AbstractRector
{
/**
* @var AssignManipulator
*/
private $assignManipulator;
public function __construct(AssignManipulator $assignManipulator)
{
$this->assignManipulator = $assignManipulator;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'each() function is deprecated, use foreach() instead.',
[
new CodeSample(
<<<'CODE_SAMPLE'
while (list($key, $callback) = each($callbacks)) {
// ...
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
foreach ($callbacks as $key => $callback) {
// ...
}
CODE_SAMPLE
),
new CodeSample(
<<<'CODE_SAMPLE'
while (list($key) = each($callbacks)) {
// ...
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
foreach (array_keys($callbacks) as $key) {
// ...
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [While_::class];
}
/**
* @param While_ $node
*/
public function refactor(Node $node): ?Node
{
if (! $node->cond instanceof Assign) {
return null;
}
/** @var Assign $assignNode */
$assignNode = $node->cond;
if (! $this->assignManipulator->isListToEachAssign($assignNode)) {
return null;
}
/** @var FuncCall $eachFuncCall */
$eachFuncCall = $assignNode->expr;
/** @var List_ $listNode */
$listNode = $assignNode->var;
$foreachedExpr = count($listNode->items) === 1 ? $this->nodeFactory->createFuncCall(
'array_keys',
[$eachFuncCall->args[0]]
) : $eachFuncCall->args[0]->value;
/** @var ArrayItem $arrayItem */
$arrayItem = array_pop($listNode->items);
$foreach = new Foreach_($foreachedExpr, $arrayItem, [
'stmts' => $node->stmts,
]);
$this->mirrorComments($foreach, $node);
// is key included? add it to foreach
if ($listNode->items !== []) {
/** @var ArrayItem|null $keyItem */
$keyItem = array_pop($listNode->items);
if ($keyItem !== null) {
$foreach->keyVar = $keyItem->value;
}
}
return $foreach;
}
}