forked from rectorphp/rector
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathServiceGetterToConstructorInjectionRector.php
178 lines (151 loc) · 4.67 KB
/
ServiceGetterToConstructorInjectionRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
<?php
declare(strict_types=1);
namespace Rector\Transform\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassLike;
use PHPStan\Type\ObjectType;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\Naming\Naming\PropertyNaming;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Transform\ValueObject\ServiceGetterToConstructorInjection;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;
/**
* @see \Rector\Tests\Transform\Rector\MethodCall\ServiceGetterToConstructorInjectionRector\ServiceGetterToConstructorInjectionRectorTest
*/
final class ServiceGetterToConstructorInjectionRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @var string
*/
public const METHOD_CALL_TO_SERVICES = 'method_call_to_services';
/**
* @var ServiceGetterToConstructorInjection[]
*/
private $methodCallToServices = [];
/**
* @var PropertyNaming
*/
private $propertyNaming;
public function __construct(PropertyNaming $propertyNaming)
{
$this->propertyNaming = $propertyNaming;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Get service call to constructor injection', [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
final class SomeClass
{
/**
* @var FirstService
*/
private $firstService;
public function __construct(FirstService $firstService)
{
$this->firstService = $firstService;
}
public function run()
{
$anotherService = $this->firstService->getAnotherService();
$anotherService->run();
}
}
class FirstService
{
/**
* @var AnotherService
*/
private $anotherService;
public function __construct(AnotherService $anotherService)
{
$this->anotherService = $anotherService;
}
public function getAnotherService(): AnotherService
{
return $this->anotherService;
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
final class SomeClass
{
/**
* @var FirstService
*/
private $firstService;
/**
* @var AnotherService
*/
private $anotherService;
public function __construct(FirstService $firstService, AnotherService $anotherService)
{
$this->firstService = $firstService;
$this->anotherService = $anotherService;
}
public function run()
{
$anotherService = $this->anotherService;
$anotherService->run();
}
}
CODE_SAMPLE
,
[
self::METHOD_CALL_TO_SERVICES => [
new ServiceGetterToConstructorInjection('FirstService', 'getAnotherService', 'AnotherService'),
],
]
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?Node
{
$classLike = $node->getAttribute(AttributeKey::CLASS_NODE);
if (! $classLike instanceof ClassLike) {
return null;
}
if ($this->classAnalyzer->isAnonymousClass($classLike)) {
return null;
}
foreach ($this->methodCallToServices as $methodCallToService) {
if (! $this->isObjectType($node->var, $methodCallToService->getOldObjectType())) {
continue;
}
if (! $this->isName($node->name, $methodCallToService->getOldMethod())) {
continue;
}
$serviceObjectType = new ObjectType($methodCallToService->getServiceType());
$propertyName = $this->propertyNaming->fqnToVariableName($serviceObjectType);
/** @var Class_ $classLike */
$this->addConstructorDependencyToClass($classLike, $serviceObjectType, $propertyName);
return new PropertyFetch(new Variable('this'), new Identifier($propertyName));
}
return $node;
}
public function configure(array $configuration): void
{
$methodCallToServices = $configuration[self::METHOD_CALL_TO_SERVICES] ?? [];
Assert::allIsInstanceOf($methodCallToServices, ServiceGetterToConstructorInjection::class);
$this->methodCallToServices = $methodCallToServices;
}
}