forked from rectorphp/rector
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathStaticCallToMethodCallRector.php
171 lines (147 loc) · 4.99 KB
/
StaticCallToMethodCallRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
<?php
declare(strict_types=1);
namespace Rector\Transform\Rector\StaticCall;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Exception\ShouldNotHappenException;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Transform\NodeAnalyzer\FuncCallStaticCallToMethodCallAnalyzer;
use Rector\Transform\ValueObject\StaticCallToMethodCall;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use Webmozart\Assert\Assert;
/**
* @see \Rector\Tests\Transform\Rector\StaticCall\StaticCallToMethodCallRector\StaticCallToMethodCallRectorTest
*/
final class StaticCallToMethodCallRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @api
* @var string
*/
public const STATIC_CALLS_TO_METHOD_CALLS = 'static_calls_to_method_calls';
/**
* @var StaticCallToMethodCall[]
*/
private $staticCallsToMethodCalls = [];
/**
* @var FuncCallStaticCallToMethodCallAnalyzer
*/
private $funcCallStaticCallToMethodCallAnalyzer;
public function __construct(FuncCallStaticCallToMethodCallAnalyzer $funcCallStaticCallToMethodCallAnalyzer)
{
$this->funcCallStaticCallToMethodCallAnalyzer = $funcCallStaticCallToMethodCallAnalyzer;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Change static call to service method via constructor injection', [
new ConfiguredCodeSample(
<<<'CODE_SAMPLE'
use Nette\Utils\FileSystem;
class SomeClass
{
public function run()
{
return FileSystem::write('file', 'content');
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use Symplify\SmartFileSystem\SmartFileSystem;
class SomeClass
{
/**
* @var SmartFileSystem
*/
private $smartFileSystem;
public function __construct(SmartFileSystem $smartFileSystem)
{
$this->smartFileSystem = $smartFileSystem;
}
public function run()
{
return $this->smartFileSystem->dumpFile('file', 'content');
}
}
CODE_SAMPLE
, [
self::STATIC_CALLS_TO_METHOD_CALLS => [
new StaticCallToMethodCall(
'Nette\Utils\FileSystem',
'write',
'Symplify\SmartFileSystem\SmartFileSystem',
'dumpFile'
),
],
]),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [StaticCall::class];
}
/**
* @param StaticCall $node
*/
public function refactor(Node $node): ?Node
{
$classLike = $node->getAttribute(AttributeKey::CLASS_NODE);
if (! $classLike instanceof Class_) {
return null;
}
$classMethod = $node->getAttribute(AttributeKey::METHOD_NODE);
if (! $classMethod instanceof ClassMethod) {
return null;
}
foreach ($this->staticCallsToMethodCalls as $staticCallToMethodCall) {
if (! $staticCallToMethodCall->isStaticCallMatch($node)) {
continue;
}
if ($classMethod->isStatic()) {
return $this->refactorToInstanceCall($node, $staticCallToMethodCall);
}
$expr = $this->funcCallStaticCallToMethodCallAnalyzer->matchTypeProvidingExpr(
$classLike,
$classMethod,
$staticCallToMethodCall->getClassObjectType()
);
if ($staticCallToMethodCall->getMethodName() === '*') {
$methodName = $this->getName($node->name);
} else {
$methodName = $staticCallToMethodCall->getMethodName();
}
if (! is_string($methodName)) {
throw new ShouldNotHappenException();
}
return new MethodCall($expr, $methodName, $node->args);
}
return $node;
}
/**
* @param array<string, mixed> $configuration
*/
public function configure(array $configuration): void
{
$staticCallsToMethodCalls = $configuration[self::STATIC_CALLS_TO_METHOD_CALLS] ?? [];
Assert::allIsInstanceOf($staticCallsToMethodCalls, StaticCallToMethodCall::class);
$this->staticCallsToMethodCalls = $staticCallsToMethodCalls;
}
private function refactorToInstanceCall(
StaticCall $staticCall,
StaticCallToMethodCall $staticCallToMethodCall
): MethodCall {
$new = new New_(new FullyQualified($staticCallToMethodCall->getClassType()));
return new MethodCall($new, $staticCallToMethodCall->getMethodName(), $staticCall->args);
}
}