Skip to content

Commit ca09ad5

Browse files
committed
- Removed dependency if URLSearchParams
1 parent dd9019c commit ca09ad5

File tree

3 files changed

+29
-15
lines changed

3 files changed

+29
-15
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
# Changelog
22
All notable changes to this project will be documented in this file.
33

4+
## [0.16.2] - 2021-01-26
5+
### Fixed
6+
- Removed dependency on `URLSearchParams` to support browser and node without any additional imports
7+
48
## [0.16.1] - 2021-01-26
9+
### Fixed
510
- Correct export inside `index.ts` when giving a custom name
611

712
## [0.16.0] - 2021-01-25

src/templates/core/functions/getQueryString.hbs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
const getQueryString = (params: Record<string, any>): string => {
2-
const searchParams = new URLSearchParams();
2+
const qs: string[] = [];
3+
4+
const append = (key: string, value: any) => {
5+
qs.push(`${encodeURIComponent(key)}=${encodeURIComponent(String(value))}`);
6+
};
37

48
const process = (key: string, value: any) => {
59
if (isDefined(value)) {
@@ -12,7 +16,7 @@ const getQueryString = (params: Record<string, any>): string => {
1216
process(`${key}[${k}]`, v);
1317
});
1418
} else {
15-
searchParams.append(key, value);
19+
append(key, value);
1620
}
1721
}
1822
};
@@ -21,9 +25,8 @@ const getQueryString = (params: Record<string, any>): string => {
2125
process(key, value);
2226
});
2327

24-
const query = searchParams.toString();
25-
if (query.length) {
26-
return `?${query}`;
28+
if (qs.length > 0) {
29+
return `?${qs.join('&')}`;
2730
}
2831

2932
return '';

test/__snapshots__/index.spec.ts.snap

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,11 @@ const base64 = (str: string): string => {
271271
};
272272

273273
const getQueryString = (params: Record<string, any>): string => {
274-
const searchParams = new URLSearchParams();
274+
const qs: string[] = [];
275+
276+
const append = (key: string, value: any) => {
277+
qs.push(\`\${encodeURIComponent(key)}=\${encodeURIComponent(String(value))}\`);
278+
};
275279

276280
const process = (key: string, value: any) => {
277281
if (isDefined(value)) {
@@ -284,7 +288,7 @@ const getQueryString = (params: Record<string, any>): string => {
284288
process(\`\${key}[\${k}]\`, v);
285289
});
286290
} else {
287-
searchParams.append(key, value);
291+
append(key, value);
288292
}
289293
}
290294
};
@@ -293,9 +297,8 @@ const getQueryString = (params: Record<string, any>): string => {
293297
process(key, value);
294298
});
295299

296-
const query = searchParams.toString();
297-
if (query.length) {
298-
return \`?\${query}\`;
300+
if (qs.length > 0) {
301+
return \`?\${qs.join('&')}\`;
299302
}
300303

301304
return '';
@@ -3168,7 +3171,11 @@ const base64 = (str: string): string => {
31683171
};
31693172

31703173
const getQueryString = (params: Record<string, any>): string => {
3171-
const searchParams = new URLSearchParams();
3174+
const qs: string[] = [];
3175+
3176+
const append = (key: string, value: any) => {
3177+
qs.push(\`\${encodeURIComponent(key)}=\${encodeURIComponent(String(value))}\`);
3178+
};
31723179

31733180
const process = (key: string, value: any) => {
31743181
if (isDefined(value)) {
@@ -3181,7 +3188,7 @@ const getQueryString = (params: Record<string, any>): string => {
31813188
process(\`\${key}[\${k}]\`, v);
31823189
});
31833190
} else {
3184-
searchParams.append(key, value);
3191+
append(key, value);
31853192
}
31863193
}
31873194
};
@@ -3190,9 +3197,8 @@ const getQueryString = (params: Record<string, any>): string => {
31903197
process(key, value);
31913198
});
31923199

3193-
const query = searchParams.toString();
3194-
if (query.length) {
3195-
return \`?\${query}\`;
3200+
if (qs.length > 0) {
3201+
return \`?\${qs.join('&')}\`;
31963202
}
31973203

31983204
return '';

0 commit comments

Comments
 (0)