Skip to content

Migrate _web packages to package:web, etc to support Wasm #12027

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
kevmoo opened this issue Dec 12, 2023 · 8 comments
Closed

Migrate _web packages to package:web, etc to support Wasm #12027

kevmoo opened this issue Dec 12, 2023 · 8 comments
Assignees
Labels
platform: web Issues / PRs which are specifically for web. resolution: fixed A fix has been merged or is pending merge from a PR. type: enhancement New feature or request type: infrastructure Improvements to the codebase

Comments

@kevmoo
Copy link
Collaborator

kevmoo commented Dec 12, 2023

We are working on public documentation for this process, but creating this issue as a placeholder.

The short version:

  • Migrate usage of dart:html to package:web
  • Migrate usage of dart:js, dart:js_util, and package:js to dart:js_interop
@IchordeDionysos
Copy link
Contributor

@Lyokone could we add a checklist of things that need to be done aka. packages that still need to be migrated to a TODO list in this issue?

e.g., Remote Config and Performance Monitoring, ... are also still open but have no PR yet.
And at the end, as I understand it, we'd have to remove js from all packages?!

@The-RootCause
Copy link

@Lyokone Thank you.
Is there a any projection when the plugin can be compatible with Wasm ?
The current plugin is not compatible yet with wasm, which is blocking all firebase related plugins from being compatible with wasm,

@IchordeDionysos
Copy link
Contributor

Related issue: #12466

@MominRaza
Copy link
Contributor

web_plugin_registrant.dart => package:firebase_app_check_web => dart:html
App check is still using dart:html

@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 5, 2024

web_plugin_registrant.dart => package:firebase_app_check_web => dart:html
App check is still using dart:html

Thanks @MominRaza ! See #12597

@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 8, 2024

We can close this out now, right @MominRaza ?

@MominRaza
Copy link
Contributor

Now I'm able to build with --wasm, yes now you can close this issue.
Thanks

@kevmoo
Copy link
Collaborator Author

kevmoo commented Apr 14, 2024

Well done, folks!

@kevmoo kevmoo closed this as completed Apr 14, 2024
@TarekkMA TarekkMA added the resolution: fixed A fix has been merged or is pending merge from a PR. label Apr 16, 2024
@firebase firebase locked and limited conversation to collaborators May 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
platform: web Issues / PRs which are specifically for web. resolution: fixed A fix has been merged or is pending merge from a PR. type: enhancement New feature or request type: infrastructure Improvements to the codebase
Projects
None yet
Development

No branches or pull requests

7 participants