Skip to content

upgrade js dependency to js 0.7.1 #12355

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Yoda-Man opened this issue Feb 20, 2024 · 4 comments
Closed

upgrade js dependency to js 0.7.1 #12355

Yoda-Man opened this issue Feb 20, 2024 · 4 comments
Assignees
Labels
platform: web Issues / PRs which are specifically for web. resolution: duplicate This issue or pull request already exists type: enhancement New feature or request

Comments

@Yoda-Man
Copy link

The package currently runs on js ^0.6.3 which is really old

@Yoda-Man Yoda-Man added Needs Attention This issue needs maintainer attention. type: enhancement New feature or request labels Feb 20, 2024
@danagbemava-nc danagbemava-nc added triage Issue is currently being triaged. platform: web Issues / PRs which are specifically for web. and removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Feb 20, 2024
@deepak-agendaboa
Copy link

The recommendation is to use dart:js_interop as mentioned here

@timmolter
Copy link

timmolter commented Feb 21, 2024

yes, please update as it clashes with flutter_native_splash.

Because no versions of flutter_native_splash match >2.3.13 <3.0.0 and flutter_native_splash 2.3.13 depends on js ^0.7.1, flutter_native_splash ^2.3.13 requires js ^0.7.1.
And because firebase_core >=2.25.4 depends on firebase_core_web ^2.11.4 which depends on js ^0.6.3, flutter_native_splash ^2.3.13 is incompatible with firebase_core >=2.25.4.
So, because readable_english_app depends on both firebase_core ^2.25.4 and flutter_native_splash ^2.3.13, version solving failed.

@Lyokone
Copy link
Contributor

Lyokone commented Feb 23, 2024

We are in the process of moving to dart:js_interop. Once all packages are migrated we will remove the js dependency.

@Lyokone Lyokone self-assigned this Feb 23, 2024
@Lyokone
Copy link
Contributor

Lyokone commented Mar 11, 2024

Closing in favor of #12466

@Lyokone Lyokone closed this as completed Mar 11, 2024
@firebase firebase locked and limited conversation to collaborators Apr 11, 2024
@TarekkMA TarekkMA added the resolution: duplicate This issue or pull request already exists label Apr 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
platform: web Issues / PRs which are specifically for web. resolution: duplicate This issue or pull request already exists type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants