Skip to content

get_custom_object and other tests/snippets should not rely on toString to verify custom object types #369

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
puf opened this issue Apr 30, 2024 · 0 comments

Comments

@puf
Copy link
Contributor

puf commented Apr 30, 2024

The toString() method exists on each Object already, so it is not a great example to highlight that we get a custom object type back when using withConverter. I recommend using name, state, and/or country instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant