Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Declaring support for Django 5.0 (and Python 3.12)? #265

Open
jonafato opened this issue May 3, 2024 · 1 comment · May be fixed by #266
Open

Declaring support for Django 5.0 (and Python 3.12)? #265

jonafato opened this issue May 3, 2024 · 1 comment · May be fixed by #266
Labels
enhancement Enhancement of an existing feature

Comments

@jonafato
Copy link

jonafato commented May 3, 2024

djangorestframework-api-key currently declares Django 4.2 and Python 3.11 as the latest supported versions. Aside from an easily fixable test failure (details below), a local pytest run suggests that everything works on Django 5.0 and Python 3.12. I'd be happy to submit a PR for these minor changes.


Details of minor test failures: three parametrized tests (tests/test_model.py::test_has_expired) fail with the following type error:

TypeError: can't compare offset-naive and offset-aware datetimes

This error is rooted in a change to the default behavior of the USE_TZ setting in 5.0. Based on Django's own defaults and recommendations, changing to use timezones by default (in conftest.py and dateutils.py) seems reasonable, but setting USE_TZ to False also gets tests passing consistently across versions.

@florimondmanca
Copy link
Owner

Hi there!

Vert happy to review a PR indeed. In most cases these version support bumps have been mostly painless.

@florimondmanca florimondmanca added help wanted Extra attention is needed enhancement Enhancement of an existing feature and removed help wanted Extra attention is needed labels May 3, 2024
@jonafato jonafato linked a pull request May 3, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants