Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Inspector V2] Implementation widgets erroneously included in widget tree [package:stager] #8802

Open
elliette opened this issue Jan 23, 2025 · 3 comments
Labels
inspector-2.0-polish Polish work that can be tackled once Inspector 2.0 has landed. P2 important to work on, but not at the top of the work list. screen: inspector

Comments

@elliette
Copy link
Member

elliette commented Jan 23, 2025

I noticed when running the Property Editor, many widgets from the Flutter framework are being erroneously being considered widgets created by the local project, and therefore being included in the widget tree even when implementation widgets are hidden.

I don't see the same behavior when running DevTools itself, and my best guess why this is occurring is because we are running the Property Editor as a stager app.

Note: The implementation widgets are also included in the summary tree of the legacy inspector, so this is not unique to the new inspector.

@elliette elliette added inspector-2.0-polish Polish work that can be tackled once Inspector 2.0 has landed. P2 important to work on, but not at the top of the work list. screen: inspector labels Jan 23, 2025
@elliette
Copy link
Member Author

I think this is because we were launching the property editor from DevTools root, and not from the packages/devtools_app. Launching from devtools_app resolves this.

@elliette
Copy link
Member Author

Found related but separate issue for widget preview integration, filed #8807

@elliette
Copy link
Member Author

See comment here: #8806 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
inspector-2.0-polish Polish work that can be tackled once Inspector 2.0 has landed. P2 important to work on, but not at the top of the work list. screen: inspector
Projects
None yet
Development

No branches or pull requests

1 participant