diff --git a/flutter-idea/src/io/flutter/FlutterErrorReportSubmitter.java b/flutter-idea/src/io/flutter/FlutterErrorReportSubmitter.java index 51a2df74fa..888a83be2c 100644 --- a/flutter-idea/src/io/flutter/FlutterErrorReportSubmitter.java +++ b/flutter-idea/src/io/flutter/FlutterErrorReportSubmitter.java @@ -226,7 +226,6 @@ private static void fail(@NotNull Consumer consumer) { } private static byte[] readFully(InputStream in) throws IOException { - //noinspection resource final ByteArrayOutputStream out = new ByteArrayOutputStream(); final byte[] temp = new byte[4096]; int count = in.read(temp); diff --git a/flutter-idea/src/io/flutter/actions/ReloadAllFlutterApps.java b/flutter-idea/src/io/flutter/actions/ReloadAllFlutterApps.java index 8cfb6d256f..988919f840 100644 --- a/flutter-idea/src/io/flutter/actions/ReloadAllFlutterApps.java +++ b/flutter-idea/src/io/flutter/actions/ReloadAllFlutterApps.java @@ -21,7 +21,6 @@ /** * Action that reloads all running Flutter apps. */ -@SuppressWarnings("ComponentNotRegistered") public class ReloadAllFlutterApps extends FlutterAppAction { public static final String ID = "Flutter.ReloadAllFlutterApps"; //NON-NLS public static final String TEXT = FlutterBundle.message("app.reload.all.action.text"); diff --git a/flutter-idea/src/io/flutter/actions/RestartAllFlutterApps.java b/flutter-idea/src/io/flutter/actions/RestartAllFlutterApps.java index e3ffdf1d72..53b9d7e063 100644 --- a/flutter-idea/src/io/flutter/actions/RestartAllFlutterApps.java +++ b/flutter-idea/src/io/flutter/actions/RestartAllFlutterApps.java @@ -19,7 +19,6 @@ /** * Action that restarts all running Flutter apps. */ -@SuppressWarnings("ComponentNotRegistered") public class RestartAllFlutterApps extends FlutterAppAction { public static final String ID = "Flutter.RestartAllFlutterApps"; //NON-NLS public static final String TEXT = FlutterBundle.message("app.restart.all.action.text"); diff --git a/flutter-idea/src/io/flutter/editor/FlutterIconLineMarkerProvider.java b/flutter-idea/src/io/flutter/editor/FlutterIconLineMarkerProvider.java index 02fe179783..eb58c9a2ab 100644 --- a/flutter-idea/src/io/flutter/editor/FlutterIconLineMarkerProvider.java +++ b/flutter-idea/src/io/flutter/editor/FlutterIconLineMarkerProvider.java @@ -295,7 +295,6 @@ private String getBasePathForFamily(@NotNull String family, @NotNull FlutterSdk private LineMarkerInfo createLineMarker(@Nullable PsiElement element, @NotNull Icon icon) { if (element == null) return null; assert element.getTextRange() != null; - //noinspection MissingRecentApi return new LineMarkerInfo<>(element, element.getTextRange(), icon, null, null, GutterIconRenderer.Alignment.LEFT, () -> ""); } diff --git a/flutter-idea/src/io/flutter/jxbrowser/JxBrowserManager.java b/flutter-idea/src/io/flutter/jxbrowser/JxBrowserManager.java index 77f1e288be..1de99018f1 100644 --- a/flutter-idea/src/io/flutter/jxbrowser/JxBrowserManager.java +++ b/flutter-idea/src/io/flutter/jxbrowser/JxBrowserManager.java @@ -157,7 +157,6 @@ public void settingsChanged() { final FlutterSettings settings = FlutterSettings.getInstance(); // Set up JxBrowser files if the embedded inspector option has been turned on and the files aren't already loaded. - //noinspection ConstantConditions if (getStatus().equals(JxBrowserStatus.NOT_INSTALLED)) { setUp(projectName); } diff --git a/flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java b/flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java index 5a9836a3c2..08c6286c1a 100644 --- a/flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java +++ b/flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java @@ -111,7 +111,6 @@ public void projectOpened(@NotNull Project project) { } //noinspection ConstantConditions StartupManager.getInstance(project).runAfterOpened(() -> { - //noinspection ConstantConditions DumbService.getInstance(project).smartInvokeLater(() -> { for (ModuleDescriptor module : modules) { assert module != null; diff --git a/flutter-idea/src/io/flutter/run/test/DartTestLocationProviderZ.java b/flutter-idea/src/io/flutter/run/test/DartTestLocationProviderZ.java index d22f82ae12..fa7e6c96cf 100644 --- a/flutter-idea/src/io/flutter/run/test/DartTestLocationProviderZ.java +++ b/flutter-idea/src/io/flutter/run/test/DartTestLocationProviderZ.java @@ -34,7 +34,6 @@ import java.util.Collections; import java.util.List; -@SuppressWarnings("Duplicates") public class DartTestLocationProviderZ implements SMTestLocator, DumbAware { @SuppressWarnings("rawtypes") private static final List NONE = Collections.emptyList(); diff --git a/flutter-idea/src/io/flutter/survey/FlutterSurveyNotifications.java b/flutter-idea/src/io/flutter/survey/FlutterSurveyNotifications.java index e5a912fda0..42ade98823 100644 --- a/flutter-idea/src/io/flutter/survey/FlutterSurveyNotifications.java +++ b/flutter-idea/src/io/flutter/survey/FlutterSurveyNotifications.java @@ -97,7 +97,6 @@ private void checkForDisplaySurvey() { null ); - //noinspection DialogTitleCapitalization notification.addAction(new AnAction(SURVEY_ACTION_TEXT) { @Override public void actionPerformed(@NotNull AnActionEvent event) { @@ -109,7 +108,6 @@ public void actionPerformed(@NotNull AnActionEvent event) { } }); - //noinspection DialogTitleCapitalization notification.addAction(new AnAction(SURVEY_DISMISSAL_TEXT) { @Override public void actionPerformed(@NotNull AnActionEvent event) { diff --git a/flutter-idea/src/io/flutter/test/DartTestEventsConverterZ.java b/flutter-idea/src/io/flutter/test/DartTestEventsConverterZ.java index f2f1be490d..f61b1fa786 100644 --- a/flutter-idea/src/io/flutter/test/DartTestEventsConverterZ.java +++ b/flutter-idea/src/io/flutter/test/DartTestEventsConverterZ.java @@ -32,7 +32,7 @@ * event followed some time later by an 'error' event for that same test. That should * convert a successful test into a failure. That case is not being handled. */ -@SuppressWarnings({"Duplicates", "FieldMayBeFinal", "LocalCanBeFinal", "SameReturnValue"}) +@SuppressWarnings({"FieldMayBeFinal", "LocalCanBeFinal", "SameReturnValue"}) public class DartTestEventsConverterZ extends OutputToGeneralTestEventsConverter { private static final Logger LOG = Logger.getInstance(DartTestEventsConverterZ.class); @@ -156,7 +156,6 @@ private boolean doProcessServiceMessages(@NotNull final String text) throws Pars return super.processServiceMessages(text, myCurrentOutputType, myCurrentVisitor); } - @SuppressWarnings("SimplifiableIfStatement") private boolean process(JsonObject obj) throws JsonSyntaxException, ParseException { String type = obj.get(JSON_TYPE).getAsString(); if (TYPE_TEST_START.equals(type)) { diff --git a/flutter-idea/src/io/flutter/vmService/DartVmServiceListener.java b/flutter-idea/src/io/flutter/vmService/DartVmServiceListener.java index 93459774d7..237c238213 100644 --- a/flutter-idea/src/io/flutter/vmService/DartVmServiceListener.java +++ b/flutter-idea/src/io/flutter/vmService/DartVmServiceListener.java @@ -40,7 +40,6 @@ public void connectionOpened() { } - @SuppressWarnings("DuplicateBranchesInSwitch") @Override public void received(@NotNull final String streamId, @NotNull final Event event) { switch (event.getKind()) { diff --git a/flutter-idea/testSrc/unit/io/flutter/ide/DartTestUtils.java b/flutter-idea/testSrc/unit/io/flutter/ide/DartTestUtils.java index 13eac0d103..72c4ff81c8 100644 --- a/flutter-idea/testSrc/unit/io/flutter/ide/DartTestUtils.java +++ b/flutter-idea/testSrc/unit/io/flutter/ide/DartTestUtils.java @@ -57,7 +57,6 @@ public static void configureFlutterSdk(@NotNull final Module module, @NotNull fi //final String dartSdkHome = sdkHome + "bin/cache/dart-sdk"; //VfsRootAccess.allowRootAccess(disposable, dartSdkHome); - //noinspection ConstantConditions //ApplicationManager.getApplication().runWriteAction(() -> { // Disposer.register(disposable, DartSdkLibUtil.configureDartSdkAndReturnUndoingDisposable(module.getProject(), dartSdkHome)); // Disposer.register(disposable, DartSdkLibUtil.enableDartSdkAndReturnUndoingDisposable(module)); diff --git a/flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java b/flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java index a28ee71a9d..3aef4efff2 100644 --- a/flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java +++ b/flutter-studio/src/io/flutter/android/AndroidModuleLibraryManager.java @@ -218,13 +218,11 @@ private void doGradleSync(Project flutterProject, Function callba Disposer.register(flutterProject, androidProject); GradleSyncListener listener = new GradleSyncListener() { - @SuppressWarnings("override") public void syncTaskCreated(@NotNull Project project, @NotNull GradleSyncInvoker.Request request) {} // TODO(messick) Remove when 3.6 is stable. public void syncStarted(@NotNull Project project, boolean skipped, boolean sourceGenerationRequested) {} - @SuppressWarnings("override") public void setupStarted(@NotNull Project project) {} @Override diff --git a/flutter-studio/src/io/flutter/utils/AddToAppUtils.java b/flutter-studio/src/io/flutter/utils/AddToAppUtils.java index 44da318b99..2cfe1f5c79 100644 --- a/flutter-studio/src/io/flutter/utils/AddToAppUtils.java +++ b/flutter-studio/src/io/flutter/utils/AddToAppUtils.java @@ -119,7 +119,6 @@ public void syncSkipped(@NotNull Project project) { GradleUtils.checkDartSupport(project); } - @SuppressWarnings("override") public void sourceGenerationFinished(@NotNull Project project) { } }; diff --git a/flutter-studio/src/io/flutter/utils/GradleUtils.java b/flutter-studio/src/io/flutter/utils/GradleUtils.java index d681be2559..8792176cd0 100644 --- a/flutter-studio/src/io/flutter/utils/GradleUtils.java +++ b/flutter-studio/src/io/flutter/utils/GradleUtils.java @@ -276,7 +276,6 @@ private static boolean isCoeditTransformedProject(@NotNull Project project) { // Copied from org.jetbrains.plugins.gradle.execution.GradleRunAnythingProvider. @NotNull - @SuppressWarnings("DuplicatedCode") private static Map> getTasksMap(Project project) { Map> tasks = new LinkedHashMap<>(); for (GradleProjectSettings setting : GradleSettings.getInstance(project).getLinkedProjectsSettings()) { @@ -458,7 +457,6 @@ private String readSettingsFile() { try { requireNonNull(pathToModule); requireNonNull(settingsFile); - @SuppressWarnings({"IOResourceOpenedButNotSafelyClosed", "resource"}) BufferedInputStream str = new BufferedInputStream(settingsFile.getInputStream()); return FileUtil.loadTextAndClose(new InputStreamReader(str, CharsetToolkit.UTF8_CHARSET)); }