From f25b4bc3f79a55306c01f973aaee27937787c13b Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Wed, 22 Jan 2025 16:12:41 -0800 Subject: [PATCH 1/3] Add a PR template that explains updating `tests.version` Part of https://github.com/flutter/flutter/pull/162048. --- .github/pull_request_template.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..e02c92cb --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,16 @@ + + +*Replace this description with a description of what your PR is changing, adding, enabling, or disabling.* + +> [!IMPORTANT] +> This repository is a testing suite that contains references to tests (in the `registry` directory) that are run with every commit to Flutter +> to verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is _not_ automatically run in the +> Flutter CI tree. +> +> Once merged, a PR must be sent updating `dev/customer_testing/tests.version` with the latest SHA. +> +> See for details. From c1ac18e96e24e4f267f08f41f2dcbfc81f2b0c6e Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Wed, 22 Jan 2025 16:21:45 -0800 Subject: [PATCH 2/3] Update .github/pull_request_template.md Co-authored-by: Zachary Anderson --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e02c92cb..a8255256 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,6 +11,6 @@ To learn more about code review, see our documentation on Tree Hygiene: https:// > to verify that no breaking changes have been introduced (in the "customer_testing" shards). Your merged PR is _not_ automatically run in the > Flutter CI tree. > -> Once merged, a PR must be sent updating `dev/customer_testing/tests.version` with the latest SHA. +> After merging this PR, you must send another PR to flutter/flutter updating `dev/customer_testing/tests.version` in that repo with the latest git commit SHA of the flutter/test repo. > > See for details. From 4aa0a6193a0bd0b1b4e2d2b43298bd9042a95111 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Fri, 24 Jan 2025 10:15:07 -0800 Subject: [PATCH 3/3] Update pull_request_template.md --- .github/pull_request_template.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a8255256..6558fa7c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,3 +14,26 @@ To learn more about code review, see our documentation on Tree Hygiene: https:// > After merging this PR, you must send another PR to flutter/flutter updating `dev/customer_testing/tests.version` in that repo with the latest git commit SHA of the flutter/test repo. > > See for details. + +## Pre-launch Checklist + +- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. +- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. +- [ ] I read the [Flutter Style Guide] _recently_, and have followed its advice. +- [ ] I signed the [CLA]. +- [ ] I listed at least one issue that this PR fixes in the description above. +- [ ] I updated/added relevant documentation (doc comments with `///`). +- [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. +- [ ] All existing and new tests are passing. + +If you need help, consider asking for advice on the #hackers-new channel on [Discord]. + + +[Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview +[Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md +[test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests +[Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md +[CLA]: https://cla.developers.google.com/ +[flutter/tests]: https://github.com/flutter/tests +[breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes +[Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md