Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

textAngularSetup clear format tool should reset to default wrap #400

Closed
geyang opened this issue Nov 9, 2014 · 2 comments
Closed

textAngularSetup clear format tool should reset to default wrap #400

geyang opened this issue Nov 9, 2014 · 2 comments
Labels

Comments

@geyang
Copy link
Collaborator

geyang commented Nov 9, 2014

line 420 in textAngularSetup:

Instead of setting to <p>, we should set it to "<" + ta.defaultWrap + ">".

@SimeonC
Copy link
Collaborator

SimeonC commented Nov 9, 2014

Good point.

I think I'll have to change this to wrapSelection('formatBlock', 'default'); as the best place to do this is in the taExecCommand module.

Thanks for pointing this out.

@SimeonC SimeonC added the bug label Nov 9, 2014
@geyang
Copy link
Collaborator Author

geyang commented Nov 10, 2014

Cool! I was just thinking that you must have a better idea:)

On Sun, Nov 9, 2014 at 5:13 PM, Simeon Cheeseman notifications@github.com
wrote:

Good point.

I think I'll have to change this to wrapSelection('formatBlock',
'default'); as the best place to do this is in the taExecCommand module.

Thanks for pointing this out.


Reply to this email directly or view it on GitHub
#400 (comment)
.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants