You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Config.logLevel / DEVELOCITY_API_LOG_LEVEL internally changes org.slf4j.simpleLogger.defaultLogLevel, which changes level of all loggers, not only the library's as the javadoc says. In practice, this is an issue when the user is using simple-logger and using loggers (or using other dependencies that use loggers), as changing Config.logLevel / DEVELOCITY_API_LOG_LEVEL will unexpectedly affect those loggers.
Planned fix
Change the property's implementation to set org.slf4j.simpleLogger.log.<package> instead of org.slf4j.simpleLogger.defaultLogLevel
Ensure all library loggers are named for the library's packages (HTTP logger is currently named for okhttp3)
Despite the new behavior matching what the docs currently say ("Changes the default log level for library classes"), this is a breaking change for anyone relying on the current behavior.
The text was updated successfully, but these errors were encountered:
Config.logLevel
/DEVELOCITY_API_LOG_LEVEL
internally changesorg.slf4j.simpleLogger.defaultLogLevel
, which changes level of all loggers, not only the library's as the javadoc says. In practice, this is an issue when the user is usingsimple-logger
and using loggers (or using other dependencies that use loggers), as changingConfig.logLevel
/DEVELOCITY_API_LOG_LEVEL
will unexpectedly affect those loggers.Planned fix
org.slf4j.simpleLogger.log.<package>
instead oforg.slf4j.simpleLogger.defaultLogLevel
okhttp3
)Despite the new behavior matching what the docs currently say ("Changes the default log level for library classes"), this is a breaking change for anyone relying on the current behavior.
The text was updated successfully, but these errors were encountered: