-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
GitHub, GitLab and CircleCI logos for call to action buttons are not showing properly on Safari #493
Comments
Closes #493 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/game-ci/documentation?shareId=XXXX-XXXX-XXXX-XXXX).
Removing the |
@coderabbitai read these files: static/assets/images/icons/circleci.svg What’s your take on this? What could be causing this Safari compatibility issue that prevents SVG logos from rendering when |
Tip For best results, initiate chat on the files or code changes. @GabLeRoux The issue is related to Safari's quirky handling of SVGs within flex containers. Here are a few alternative approaches you could try:
<Link
to={url}
className="group grid place-items-center border-gray-600 border-solid rounded-sm border-2 px-6 py-3 w-[180px] h-[70px] transition-all duration-200 hover:scale-110 hover:bg-gray-600"
>
<Logo className="fill-brand-text-light dark:fill-brand-text-dark group-hover:fill-white" />
</Link>
<Link
to={url}
className="group flex items-center justify-center border-gray-600 border-solid rounded-sm border-2 px-6 py-3 w-[180px] h-[70px] transition-all duration-200 hover:scale-110 hover:bg-gray-600"
>
<div>
<Logo className="fill-brand-text-light dark:fill-brand-text-dark group-hover:fill-white" />
</div>
</Link>
<Link
to={url}
className="group flex items-center justify-center border-gray-600 border-solid rounded-sm border-2 px-6 py-3 w-[180px] h-[70px] transition-all duration-200 hover:scale-110 hover:bg-gray-600"
>
<Logo className="w-[120px] h-[25px] fill-brand-text-light dark:fill-brand-text-dark group-hover:fill-white" />
</Link> I recommend trying the grid layout approach first as it's the cleanest solution and maintains the same visual appearance while avoiding Safari's flex-related SVG rendering issues. 🔗 Analysis chain🏁 Scripts executedThe following scripts were executed for the analysis: Script:
Length of output: 12937 ✏️ Learnings added
|
Light theme on Safari :
Dark theme on Safari :
The text was updated successfully, but these errors were encountered: