Skip to content

Commit 329cccb

Browse files
authoredJul 29, 2024
Migrate from to_hash to to_h (#2351)
* Migrate from to_hash to to_h As @solnic pointed out in #2350 (comment) `to_hash` has special meaning in Ruby and could be called implicitly in contexts like double splatting argument. So we should switch to `to_h` to avoid potential issues.
1 parent 7db04c9 commit 329cccb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+185
-184
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
### Breaking Changes
44

55
- Remove `config.async` [#1894](https://github.com/getsentry/sentry-ruby/pull/1894)
6+
- Migrate from to_hash to to_h ([#2351](https://github.com/getsentry/sentry-ruby/pull/2351))
67

78
## Unreleased
89

‎sentry-delayed_job/spec/sentry/delayed_job_spec.rb

+8-8
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def do_nothing_with_args(a)
4444
enqueued_job.invoke_job
4545

4646
expect(transport.events.count).to eq(1)
47-
event = transport.events.last.to_hash
47+
event = transport.events.last.to_h
4848
expect(event[:message]).to eq("report")
4949
expect(event[:contexts][:"Delayed-Job"][:id]).to eq(enqueued_job.id.to_s)
5050
expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
@@ -66,7 +66,7 @@ def do_nothing_with_args(a)
6666
enqueued_job.invoke_job
6767

6868
expect(transport.events.count).to eq(1)
69-
event = transport.events.last.to_hash
69+
event = transport.events.last.to_h
7070
expect(event[:message]).to eq("tagged report")
7171
expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil, number: 1 })
7272

@@ -75,7 +75,7 @@ def do_nothing_with_args(a)
7575
enqueued_job.invoke_job
7676

7777
expect(transport.events.count).to eq(2)
78-
event = transport.events.last.to_hash
78+
event = transport.events.last.to_h
7979
expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
8080
end
8181

@@ -91,7 +91,7 @@ def do_nothing_with_args(a)
9191
end.to raise_error(ZeroDivisionError)
9292

9393
expect(transport.events.count).to eq(1)
94-
event = transport.events.last.to_hash
94+
event = transport.events.last.to_h
9595

9696
expect(event[:sdk]).to eq({ name: "sentry.ruby.delayed_job", version: described_class::VERSION })
9797
expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -107,7 +107,7 @@ def do_nothing_with_args(a)
107107
end.to raise_error(RuntimeError)
108108

109109
expect(transport.events.count).to eq(1)
110-
event = transport.events.last.to_hash
110+
event = transport.events.last.to_h
111111

112112
expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil, number: 1 })
113113
expect(Sentry.get_current_scope.extra).to eq({})
@@ -121,7 +121,7 @@ def do_nothing_with_args(a)
121121
end.to raise_error(ZeroDivisionError)
122122

123123
expect(transport.events.count).to eq(2)
124-
event = transport.events.last.to_hash
124+
event = transport.events.last.to_h
125125
expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
126126
expect(Sentry.get_current_scope.extra).to eq({})
127127
expect(Sentry.get_current_scope.tags).to eq({})
@@ -226,7 +226,7 @@ def perform
226226
it "injects ActiveJob information to the event" do
227227
expect(transport.events.count).to eq(1)
228228

229-
event = transport.events.last.to_hash
229+
event = transport.events.last.to_h
230230
expect(event[:message]).to eq("report from ActiveJob")
231231
expect(event[:tags]).to match({ "delayed_job.id" => anything, "delayed_job.queue" => "default", number: 1 })
232232
expect(event[:contexts][:"Active-Job"][:job_class]).to eq("ReportingJob")
@@ -253,7 +253,7 @@ def perform
253253
it "injects ActiveJob information to the event" do
254254
expect(transport.events.count).to eq(1)
255255

256-
event = transport.events.last.to_hash
256+
event = transport.events.last.to_h
257257
expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
258258
expect(event[:tags]).to match({ "delayed_job.id" => anything, "delayed_job.queue" => "default", number: 2 })
259259
expect(event[:contexts][:"Active-Job"][:job_class]).to eq("FailedJob")

0 commit comments

Comments
 (0)