Skip to content

Touch doesn't execute header menu on mobile #806

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
mjpolak opened this issue Nov 13, 2023 · 3 comments · May be fixed by #960
Open

Touch doesn't execute header menu on mobile #806

mjpolak opened this issue Nov 13, 2023 · 3 comments · May be fixed by #960
Assignees
@tanvirraj
Labels
package:core Requests related to the core package type:bug Something isn't working

Comments

@mjpolak
Copy link

mjpolak commented Nov 13, 2023

Reproduction:

  1. Go to https://grid.glideapps.com/ on mobile device
  2. Try to click on header menu

Result

The menu doesn't open

Expected result

Menu is visible
@jassmith jassmith added type:bug Something isn't working touch labels Nov 30, 2023
@tanvirraj
Copy link

tanvirraj commented Dec 18, 2023 •
edited
Loading

@jassmith , @mjpolak
i try to reproduce this issue in safari iOS, i found that this menu is not working in iOS, is this right, then i can look into this one
Screenshot 2023-12-18 at 12 48 44 PM

@jassmith
Copy link
Contributor

It would be great if you could poke at it. The solution here is that the onHeaderMenuClick event needs to emit when there is a long touch (and the other requirements for emitting this event are met). Fortunately the base implementation already tells you if the last interaction was a long touch, so this shouldn't be too hard.

@tanvirraj
Copy link

make sense. Thanks for brief intro. will look into this.

@lukasmasuch lukasmasuch added package:core Requests related to the core package and removed touch labels Dec 30, 2023
@BrianHung BrianHung linked a pull request Jun 1, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tanvirraj tanvirraj

Labels
package:core Requests related to the core package type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use pointer events instead of mouse + touch BrianHung/glide-data-grid
4 participants
@jassmith @lukasmasuch @tanvirraj @mjpolak