Skip to content

Commit 01b10bd

Browse files
authored
Merge pull request #105 from gradle-plugins/develop/api
Introduce a way to split the plugin API from implementation
2 parents da5df2a + 2304d98 commit 01b10bd

File tree

35 files changed

+1293
-48
lines changed

35 files changed

+1293
-48
lines changed

.gitmodules

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
[submodule "gradle/libraries/source-elements"]
22
path = gradle/libraries/source-elements
33
url = git@github.com:gradle-plugins/source-elements.git
4+
[submodule "gradle/libraries/gradle-build-script"]
5+
path = gradle/libraries/gradle-build-script
6+
url = git@github.com:gradle-plugins/gradle-build-script.git

README.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
:jbake-version: 1.7.2
1+
:jbake-version: 1.8.0
22
// TODO: Add test for the version above
33
= Gradle Plugin Development Toolbox
44

build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ plugins {
55
allprojects {
66
group = 'dev.gradleplugins'
77
}
8-
version = '1.7.2'
8+
version = '1.8.0'
99

1010
// Configure javadoc
1111
allprojects {
@@ -19,7 +19,7 @@ allprojects {
1919
// Configure gradle-fixtures-* versions
2020
subprojects {
2121
if (project.name.startsWith('gradle-fixtures') || project.name.startsWith('gradle-runner-kit')) {
22-
version = '0.0.146'
22+
version = '0.0.147'
2323
}
2424
}
2525

@@ -45,4 +45,4 @@ tasks.register('check') {
4545
group = 'verification'
4646
dependsOn(gradle.includedBuild('testProjects').task(":groovy-gradle-plugin:check"))
4747
dependsOn(gradle.includedBuild('testProjects').task(":java-gradle-plugin:check"))
48-
}
48+
}

buildSrc/settings.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ buildscript {
44
maven { url = 'https://repo.nokee.dev/release' }
55
}
66
dependencies {
7-
classpath 'dev.gradleplugins:gradle-plugin-development:1.7.1'
7+
classpath 'dev.gradleplugins:gradle-plugin-development:1.7.2'
88
}
99
}
1010
apply plugin: 'dev.gradleplugins.gradle-plugin-development'

gradle/libraries/gradle-build-script

Submodule gradle-build-script added at e1c2673

settings.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@ buildscript {
77
maven { url = 'https://repo.nokee.dev/release' }
88
}
99
dependencies {
10-
classpath 'dev.gradleplugins:gradle-plugin-development:1.7.1'
10+
classpath 'dev.gradleplugins:gradle-plugin-development:1.7.2'
1111
}
1212
}
1313
apply plugin: 'dev.gradleplugins.gradle-plugin-development'
1414

1515
rootProject.name = 'toolbox'
1616

17+
includeBuild 'gradle/libraries/gradle-build-script'
1718
includeBuild 'gradle/libraries/source-elements'
1819
includeBuild 'subprojects/gradle-plugin-development-test-fixtures/testProjects'
1920

subprojects/gradle-plugin-development-test-fixtures/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ plugins {
77
}
88

99
description = 'Gradle plugin development plugins test fixtures.'
10-
version = '1.7.2'
10+
version = '1.8.0'
1111

1212
dependencies {
1313
compileOnly gradleApi(minimumGradleVersion)
@@ -27,4 +27,4 @@ sourceSets.main {
2727
options.compilerArgs.add('-AbasePath=' + file('testProjects'))
2828
inputs.files(fileTree('testProjects').include('**/*.java', '**/*.groovy'))
2929
}
30-
}
30+
}

subprojects/gradle-plugin-development-test-fixtures/testProjects/settings.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
plugins {
2-
id 'dev.gradleplugins.gradle-plugin-development' version '1.7.1'
2+
id 'dev.gradleplugins.gradle-plugin-development' version '1.7.2'
33
}
44

55
include 'groovy-gradle-plugin'

subprojects/gradle-plugin-development/README.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
:jbake-version: 1.7.2
1+
:jbake-version: 1.8.0
22
= Gradle Plugin Development Plugins
33

44
The Gradle plugin development plugins are a set of plugins accelerating Gradle plugin development.

subprojects/gradle-plugin-development/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ apply plugin: 'dev.gradleplugins.gradle-plugin-unit-test'
1111
apply plugin: 'dev.gradleplugins.gradle-plugin-functional-test'
1212

1313
description = 'Gradle plugin development plugins.'
14-
version = '1.7.2'
14+
version = '1.8.0'
1515

1616
gradlePlugin {
1717
plugins {
@@ -125,6 +125,7 @@ functionalTest {
125125
implementation "org.junit.jupiter:junit-jupiter:latest.release"
126126
runtimeOnly "org.junit.vintage:junit-vintage-engine:latest.release"
127127
implementation "org.hamcrest:hamcrest:2.2"
128+
implementation "dev.gradleplugins:gradle-build-script"
128129

129130
// Force local fixtures
130131
// TODO: Maybe look into dependency substitution

subprojects/gradle-plugin-development/src/functionalTest/groovy/dev/gradleplugins/GradlePluginDevelopmentFunctionalTestingFunctionalTest.groovy

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ abstract class AbstractGradlePluginDevelopmentFunctionalTestingFunctionalTest ex
5757
buildFile << """
5858
tasks.register('verify') {
5959
doLast {
60-
assert configurations.functionalTestImplementation.dependencies.any { it instanceof ${SelfResolvingDependencyInternal.canonicalName} ? it.targetComponentId.displayName == 'Gradle TestKit' : false }
60+
assert configurations.functionalTestImplementation.incoming.dependencies.any { it instanceof ${SelfResolvingDependencyInternal.canonicalName} ? it.targetComponentId.displayName == 'Gradle TestKit' : false }
6161
}
6262
}
6363
"""

0 commit comments

Comments
 (0)