From 358d0e8af0d0fd01aad575cdff4b2321faf907c3 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 17 Feb 2025 00:47:19 +0300 Subject: [PATCH 1/3] Fix `IntrospectionQuery` type definition `TypedDict` mangles private names as regular Python classes do. So, `__schema` name will become `_IntrospectionQuery__schema` instead. See https://github.com/python/cpython/issues/129567 Found during https://github.com/python/mypy/pull/16715 --- src/graphql/utilities/get_introspection_query.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/graphql/utilities/get_introspection_query.py b/src/graphql/utilities/get_introspection_query.py index c23a1533..ab13bb50 100644 --- a/src/graphql/utilities/get_introspection_query.py +++ b/src/graphql/utilities/get_introspection_query.py @@ -302,7 +302,5 @@ class IntrospectionSchema(MaybeWithDescription): directives: list[IntrospectionDirective] -class IntrospectionQuery(TypedDict): - """The root typed dictionary for schema introspections.""" - - __schema: IntrospectionSchema +# The root typed dictionary for schema introspections. +IntrospectionQuery = TypedDict("IntrospectionQuery", [("__schema", IntrospectionSchema)]) From da87c2f36bbbf66253934c9f481c871903c89cb0 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 17 Feb 2025 19:35:36 +0300 Subject: [PATCH 2/3] Update get_introspection_query.py --- src/graphql/utilities/get_introspection_query.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/graphql/utilities/get_introspection_query.py b/src/graphql/utilities/get_introspection_query.py index ab13bb50..85a3ef32 100644 --- a/src/graphql/utilities/get_introspection_query.py +++ b/src/graphql/utilities/get_introspection_query.py @@ -303,4 +303,4 @@ class IntrospectionSchema(MaybeWithDescription): # The root typed dictionary for schema introspections. -IntrospectionQuery = TypedDict("IntrospectionQuery", [("__schema", IntrospectionSchema)]) +IntrospectionQuery = TypedDict("IntrospectionQuery", {"__schema": IntrospectionSchema}) From e5d09faa40e98f93398b2209322a3938024e505f Mon Sep 17 00:00:00 2001 From: sobolevn Date: Mon, 17 Feb 2025 21:11:20 +0300 Subject: [PATCH 3/3] Fix ruff --- src/graphql/utilities/get_introspection_query.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/graphql/utilities/get_introspection_query.py b/src/graphql/utilities/get_introspection_query.py index 85a3ef32..7b8c33bb 100644 --- a/src/graphql/utilities/get_introspection_query.py +++ b/src/graphql/utilities/get_introspection_query.py @@ -303,4 +303,7 @@ class IntrospectionSchema(MaybeWithDescription): # The root typed dictionary for schema introspections. -IntrospectionQuery = TypedDict("IntrospectionQuery", {"__schema": IntrospectionSchema}) +IntrospectionQuery = TypedDict( # noqa: UP013 + "IntrospectionQuery", + {"__schema": IntrospectionSchema}, +)