-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
smugmug_fs: handle SmugMug shenanigans that sometimes movie files #27
base: master
Are you sure you want to change the base?
Conversation
Experimentally FOO.mp4 can get renamed either to FOO_mp4.MP4 or FOO.MP4. It's unclear what triggers this behavior (presumably something about the video content, maybe something that triggers a re-encode or re-mux), but this avoids duplicating the video on every `smugcli sync` invocation for files that get renamed like this. Fixes graveljp#21. (As far as I can tell.)
Works great for mp4. This probably should be extended to include the other supported Smugmug video formats. Thanks! |
Of the other formats, I only have any .mov files handy, and they seem to consistently not trigger this behavior. |
(Obviously evidence of other behavior would be helpful - if all movies get the same behavior on upload, that's great and we can fix this PR easily, but probably better to do as a follow-up for specific behaviors as they're observed?) |
So far, it also doesn't seem to work for .avi or .m4v |
What are the renames you’re seeing?
… On Jul 28, 2021, at 2:26 PM, Scott Hansen ***@***.***> wrote:
So far, it also doesn't seem to work for .avi or .m4v
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE6LI7AZDUXQM3D65OV5DT2BDWRANCNFSM5A55HXYQ>.
|
Sorry, we're just heading out. I'm just seeing that non-mp4 file types are not getting uploaded at all. |
After playing with this for a couple of days here's what I see:
Sorry to dump all this here! I'll open issues for the other items. Thanks, |
Hi! Thanks for the contributions. And sorry for the radio silence. Could it be that SmugMug fixed the "bug" where they were putting the extension in the filename (e.g. file_mp4.MP4)? I was trying to fix MP4 sync months ago before getting into the rabbit hole of mismatching timestamps. But back then, all uploaded mp4 were renamed to "file_mp4.MP4". Using the very same sample files today, I can no longer observe this behavior, files are now named as you'd expect: "file.MP4". The same thing happened with HEIC files. To support HEIC, I had to puts the extension in the filename, but as of today, the HEIC unit test no longer works and SmugMug no longer seem to be putting "_heic" in the filename using the very same samples. Maybe, there's value in keeping the On a different note, please try to include unit tests with your pull requests. There's a pretty neat
That being said, I already have a unit test ready to test this pull request, including a very small sample "mp4" file, so don't waste time on that one. |
Experimentally FOO.mp4 can get renamed either to FOO_mp4.MP4 or
FOO.MP4. It's unclear what triggers this behavior (presumably
something about the video content, maybe something that triggers a
re-encode or re-mux), but this avoids duplicating the video on every
smugcli sync
invocation for files that get renamed like this.Fixes #21. (As far as I can tell.)