From 4748ad22a542810ecdaeee77f1bea166ebb6397a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Pardo?= Date: Thu, 27 Mar 2025 10:35:52 +0100 Subject: [PATCH] fixed data race on acknowledgedIncomingBytes in class BinderTransport.java --- .../main/java/io/grpc/binder/internal/BinderTransport.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java index f61c455edd5..99caa577e84 100644 --- a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java +++ b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java @@ -484,8 +484,8 @@ private boolean handleTransactionInternal(int code, Parcel parcel) { inbound.handleTransaction(parcel); } long nib = numIncomingBytes.addAndGet(size); - if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) { - synchronized (this) { + synchronized (this) { + if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) { sendAcknowledgeBytes(checkNotNull(outgoingBinder)); } }