Skip to content

Commit 06c4422

Browse files
committed
Remove unused and broken serial.read without explicit length
1 parent ca9adbf commit 06c4422

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/buffered_serial.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ def inWaiting(self):
3434
return len(self._buffer)
3535

3636
return super().inWaiting()
37-
38-
def read(self, num=None):
37+
38+
def read(self, num):
3939
# check if buffer can already satisfy request
4040
if len(self._buffer) >= num:
4141
retval = self._buffer[:num]
@@ -55,11 +55,7 @@ def read(self, num=None):
5555

5656
# nah, still not enough data, append more even if
5757
# that might block ...
58-
data = self._buffer
59-
if num is None:
60-
data += super().read()
61-
else:
62-
data += super().read(num - len(self._buffer))
58+
data = self._buffer + super().read(num - len(self._buffer))
6359

6460
# we'll return all data read, so buffer is now empty
6561
self._buffer = b""

0 commit comments

Comments
 (0)