Merge pull request #130 from peterdonald3/master

updated for golangci-lint

Author: hyperioxx

README.md

@@ -64,3 +64,6 @@ Golang SIP/VoIP SDK/Framework used to build large platforms for VoIP and realtim
    </tr>
 </table>
 
+
+
+

examples/basicUAC/main.go

@@ -199,7 +199,7 @@ func (c *Client) Start(host string, port int) {
 	go c.stack.Start()
 }
 
-// configure
+// configure()
 // returns pointer to ClientProperties
 func configure() *ClientProperties {
 	props := new(ClientProperties)

kalbi.go

@@ -71,7 +71,7 @@ func (ed *SipStack) Start() {
 		go listeningPoint.Start()
 	}
 
-	for ed.Alive == true {
+	for ed.Alive {
 		msg := <-ed.TransportChannel
 		event := ed.TransManager.Handle(msg)
 		message := event.GetSipMessage()

sdp/sdpAttrib.go

@@ -39,7 +39,9 @@ func (sa *sdpAttrib) String() string {
 }
 
 func parseSdpAttrib(v []byte, out *sdpAttrib) {
-	pos := 0
+	var (
+		pos int 
+	)
 	state := fieldCat
 
 	// Init the output area

sdp/sdpConnectionData.go

@@ -64,7 +64,6 @@ Exit:
 
 		case fieldConnAddr:
 			if v[pos] == ' ' {
-				pos++
 				break Exit 
 			}
 			out.ConnAddr = append(out.ConnAddr, v[pos])

sdp/sdpOrigin.go

@@ -151,8 +151,6 @@ func ParseSdpOrigin(v []byte, out *SdpOrigin) {
 			out.AddrType = append(out.AddrType, v[pos])
 		case fieldUniAddr:
 			if v[pos] == ' ' {
-				state = fieldBase
-				pos++
 				break Exit
 			}
 			out.UniAddr = append(out.UniAddr, v[pos])

sip/transaction/client.go

@@ -261,5 +261,8 @@ func (ct *ClientTransaction) Send(msg *message.SipMsg, host string, port string)
 			log.Log.Error(err)
 		}
 	}
-	ct.FSM.Event(clientInputRequest)
+	err = ct.FSM.Event(clientInputRequest)
+	if err != nil {
+		log.Log.Error(err)
+	}
 }

sip/transaction/server.go

@@ -29,14 +29,14 @@ import (
 )
 
 const (
-	serverInputRequest      = "server_input_request"
-	serverInputAck          = "server_input_ack"
-	serverInputUser1xx      = "server_input_user_1xx"
-	serverInputUser2xx      = "server_input_user_2xx"
-	serverInputUser300Plus  = "server_input_user_300_plus"
-	serverInputTimerG       = "server_input_timer_g"
-	serverInputTimerH       = "server_input_timer_h"
-	serverInputTimerI       = "server_input_timer_i"
+	serverInputRequest     = "server_input_request"
+	serverInputAck         = "server_input_ack"
+	serverInputUser1xx     = "server_input_user_1xx"
+	serverInputUser2xx     = "server_input_user_2xx"
+	serverInputUser300Plus = "server_input_user_300_plus"
+	// serverInputTimerG       = "server_input_timer_g"
+	// serverInputTimerH       = "server_input_timer_h"
+	// serverInputTimerI       = "server_input_timer_i"
 	serverInputTransportErr = "server_input_transport_err"
 	serverInputDelete       = "server_input_delete"
 )