-
Notifications
You must be signed in to change notification settings - Fork 101
Error while transforming with RN 0.64 and Typescript #43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@mppperez is your fork available on npm? |
Unfortunately not. You will have to include it manually if you want to use it. I guess with our next release we will drop this dependency as well and will check out the solution of directly use javascript-obfuscator. We've got Hermes enabled (this should generate bytecode rather than JS) but we still have the JS files that need obfuscating... this may be already the solution even for others. I guess our configuration is just not completed yet. |
I ended up publishing your fork to a private npm registry and it works well alongside Hermes. A solution using |
@mppperez @grit96 How did you manage to get hermes working with the obfuscator? More specifically, the obfuscator seems to work but then hermes recreates its own android.bundle without the obfuscation. When I disassemble the bundle I get all the original code back. Any tips? |
This is now the recommended way to do it: // metro.config.js
module.exports = {
transformer: {
minifierPath: require.resolve('metro-minify-terser')
}
} |
@grit96 Thanks! I will try. One question: is it possible to plug in the javascript obfuscator there? |
As an update, that still doesn't seem to minify my bundle. I am using hermes and this command to make a build:
But the Thoughts? |
Same issue here |
Just updated to new React Native version and it's broken again.
Output:
Already updated my fork appropriately and it works with updated dependencies (+ necessary code changes). PR will be created soon.
The text was updated successfully, but these errors were encountered: