Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Import url as part of the app URL parameter #12

Open
thejeshgn opened this issue Apr 22, 2022 · 1 comment
Open

Import url as part of the app URL parameter #12

thejeshgn opened this issue Apr 22, 2022 · 1 comment

Comments

@thejeshgn
Copy link

For example I have copied your list here. To open it if I can give a URL like this. It's so much easy to share.

https://readlists.jim-nielsen.com?import=https://data.thejeshgn.com/readlists/paul-miller-offline

  • Assuming CORS is set.
@jimniels
Copy link
Owner

I actually already semi-created this feature. It’s sitting latent in the code because I never figured the UX out entirely (or the name, maybe it should be import=...). But you can try it by passing a param titled url, i.e.

https://readlists.jim-nielsen.com/?url=https://cdn.jim-nielsen.com/readlists/paul-miller-offline.json

The UX part that's tricky is that what if you already have a readlist in localstorage, but your URL is pointing to a readlist. Which one do you use? Today it's using the one in local storage, which is the right decision I think because that's your only copy of that one, but I could see people getting confused like "why isn't the one I pointed to with url= working? Probably need some kind of hint in the UI, like this:

CleanShot 2022-05-20 at 12 39 25@2x

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants