Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support sonarqube-scanner v4 #118

Closed
1 of 2 tasks
Tommy228 opened this issue Oct 20, 2024 · 1 comment · Fixed by #120
Closed
1 of 2 tasks

Support sonarqube-scanner v4 #118

Tommy228 opened this issue Oct 20, 2024 · 1 comment · Fixed by #120
Labels
enhancement New feature or request

Comments

@Tommy228
Copy link

Which scope/s are relevant/related to the feature request?

@koliveira15/nx-sonarqube

Information

sonarqube-scanner has a new major version (v4) however nx-sonarqube does not support it currently. The executor fails with the following error

TypeError: sonarQubeScanner.async is not a function
    at node_modules/@koliveira15/nx-sonarqube/src/executors/scan/utils/utils.js:154:48
    at Generator.next (<anonymous>)
    at fulfilled (node_modules/tslib/tslib.js:166:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I think async needs to be replaced with scan.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to provide this feature

  • Yes
  • No
@Tommy228 Tommy228 added the enhancement New feature or request label Oct 20, 2024
@gcko
Copy link
Contributor

gcko commented Oct 25, 2024

@Tommy228 once PPR #117 is checked and merged into main, I can take a look at updating the version of sonarqube-scanner to latest. It will require updates to the tests as well

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants