upgrade failing due to condition of autoscaling (HPA & keda)

[karty-s]

What happened:
Hi , i am trying to upgrade from Controller version 1.9.6 (Helm 4.9.1) to v1.11.5 (Helm 4.11.5) using argo but it is failing due to the following comparison error:-

failed exit status 1: Error: template: ingress-nginx/templates/controller-deployment.yaml:21:9: executing "ingress-nginx/templates/controller-deployment.yaml" at <eq .Values.controller.autoscaling.enabled .Values.controller.keda.enabled>: error calling eq: incompatible types for comparison

We have autoscaling enabled, this is our values yaml:-

   source:
    helm:
      releaseName: ingress-nginx
      values: |-
        controller:
          admissionWebhooks:
            enabled: false
          autoscaling:
            enabled: 'true'
            maxReplicas: 6
            minReplicas: 2
            targetCPUUtilizationPercentage: 50
            targetMemoryUtilizationPercentage: 60

What you expected to happen:

Looks like comparison is failing between HPA and keda autoscaling

NGINX Ingress controller version (exec into the pod and run /nginx-ingress-controller --version): 1.9.6 to 1.11.5/1.12.1

Kubernetes version (use kubectl version): 1.30.8

Environment:

• Cloud provider or hardware configuration:

• OS (e.g. from /etc/os-release):

• Kernel (e.g. uname -a):

• Install tools:

  • Please mention how/where was the cluster created like kubeadm/kops/minikube/kind etc.

• Basic cluster related info:

  • kubectl version
  • kubectl get nodes -o wide

• How was the ingress-nginx-controller installed:

  • If helm was used then please show output of helm ls -A | grep -i ingress
  • If helm was used then please show output of helm -n <ingresscontrollernamespace> get values <helmreleasename>
  • If helm was not used, then copy/paste the complete precise command used to install the controller, along with the flags and options used
  • if you have more than one instance of the ingress-nginx-controller installed in the same cluster, please provide details for all the instances

• Current State of the controller:

  • kubectl describe ingressclasses
  • kubectl -n <ingresscontrollernamespace> get all -A -o wide
  • kubectl -n <ingresscontrollernamespace> describe po <ingresscontrollerpodname>
  • kubectl -n <ingresscontrollernamespace> describe svc <ingresscontrollerservicename>

• Current state of ingress object, if applicable:

  • kubectl -n <appnamespace> get all,ing -o wide
  • kubectl -n <appnamespace> describe ing <ingressname>
  • If applicable, then, your complete and exact curl/grpcurl command (redacted if required) and the reponse to the curl/grpcurl command with the -v flag

• Others:

  • Any other related information like ;
    • copy/paste of the snippet (if applicable)
    • kubectl describe ... of any custom configmap(s) created and in use
    • Any other related information that may help

How to reproduce this issue:
I tried to upgrade to 1.11.5 and 1.12.1 both fails. i even tried disabling the autoscaling, still fails.

Anything else we need to know:
Kindly Let me know if further info is required.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Gacko]

enabled is a boolean but you provide a string.

[karty-s]

thanks a bunch ! , this is fixed