-
Notifications
You must be signed in to change notification settings - Fork 71
lint: Add GH action to find HTTP resources returning a 404 error code #670
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
There are some links in this document that cause issues for pull request [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide Repo.
This request changes a link from http to https to fix issue [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide repo as this document is mirrored there.
This pull request changes an outdated link as it causes issue [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670). The document is mirrored on the Builder's Guide repo
This old guide hasn't been surfaced for a long while, but seems to still be present in the repo. Links in this article lead to nowhere which is causing issue lightninglabs#670
I've checked all the broken links and have fixed most of them, either by removing them or by finding the new destinations. A lot of them were in documents that are no longer available through the Builder's Guides. I have removed these pages entirely. What is left are these. I have also left my comments below as to why I didn't clean them up or what needs to be done to fix them too.
|
@Liongrass the https://lnmarkets.substack.com/p/51-ryan-gentry-on-taro-massive-stress link registers as a 403 so it's probably due to the checker being IP blocklisted |
Local check yields 200 code curl --write-out '%{http_code}' --silent --output /dev/null https://lnmarkets.substack.com/p/51-ryan-gentry-on-taro-massive-stress |
If the gif's purpose is to show the demo file structure, let's replace the gif (small size = poor readability, unclear purpose in context, tenuous file hosting) with a tree output $ tree src/components src/pages
src/components
├── MakeMeme.tsx
└── Page.tsx
src/pages
└── Home.tsx |
Fixes #365
Pull Request Checklist
docs/
directory. These files aresynced from upstream repositories (lnd, lit, loop, pool and faraday), and
should be updated in their parent repo.