Skip to content

lint: Add GH action to find HTTP resources returning a 404 error code #670

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dstadulis
Copy link

@dstadulis dstadulis commented Jul 17, 2024

Fixes #365

Pull Request Checklist

  • The documents updated are not in the docs/ directory. These files are
    synced from upstream repositories (lnd, lit, loop, pool and faraday), and
    should be updated in their parent repo.

Liongrass added a commit to Liongrass/lnd that referenced this pull request Sep 17, 2024
There are some links in this document that cause issues for pull request [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide Repo.
Liongrass added a commit to Liongrass/lnd that referenced this pull request Sep 17, 2024
This request changes a link from http to https to fix issue [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670) in the Builder's Guide repo as this document is mirrored there.
Liongrass added a commit to Liongrass/lnd that referenced this pull request Sep 17, 2024
This pull request changes an outdated link as it causes issue [lightningnetwork#670](lightninglabs/docs.lightning.engineering#670). The document is mirrored on the Builder's Guide repo
Liongrass added a commit to Liongrass/docs.lightning.engineering that referenced this pull request Sep 17, 2024
This old guide hasn't been surfaced for a long while, but seems to still be present in the repo. Links in this article lead to nowhere which is causing issue lightninglabs#670
@Liongrass
Copy link
Contributor

I've checked all the broken links and have fixed most of them, either by removing them or by finding the new destinations. A lot of them were in documents that are no longer available through the Builder's Guides. I have removed these pages entirely. What is left are these. I have also left my comments below as to why I didn't clean them up or what needs to be done to fix them too.

@djkazic
Copy link

djkazic commented Sep 18, 2024

@Liongrass the https://lnmarkets.substack.com/p/51-ryan-gentry-on-taro-massive-stress link registers as a 403 so it's probably due to the checker being IP blocklisted

@dstadulis
Copy link
Author

403 - https://lnmarkets.substack.com/p/51-ryan-gentry-on-taro-massive-stress in the file the-lightning-network/taproot-assets/README.md:66
I don't know why that would register as a 403.

Local check yields 200 code

curl --write-out '%{http_code}' --silent --output /dev/null  https://lnmarkets.substack.com/p/51-ryan-gentry-on-taro-massive-stress

@dstadulis
Copy link
Author

400 - https://lh3.googleusercontent.com/RlxBjz3zHt5ED5JltlA7FJc2dIrIlrfbYrBQv1KR6Fgf2ZchbOvF7NlywsDY4Ck8o7ABPZDj7K3g25tNp0QhH18xGqoQg5yBF4hUoxADEjWOiKu9aSF8Ty1fTOTFiweL0OFFBcMDJrKxtf3PgW/_CQDg in the file lapps/guides/make-your-own-lnc-powered-application.md:42
this is an embedded gif, but it shows nicely

If the gif's purpose is to show the demo file structure, let's replace the gif (small size = poor readability, unclear purpose in context, tenuous file hosting) with a tree output

$ tree src/components src/pages
src/components
├── MakeMeme.tsx
└── Page.tsx
src/pages
└── Home.tsx

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absent CD validation: URLs in repo with HTTP 404 error response
4 participants