Add functionality to func

Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>

Author: unsuman

pkg/driver/driver.go

@@ -71,8 +71,6 @@ type Driver interface {
 
 	// GuestAgentConn returns the guest agent connection, or nil (if forwarded by ssh).
 	GuestAgentConn(_ context.Context) (net.Conn, error)
-
-	CheckBinarySignature(_ context.Context, arch string) error
 }
 
 type BaseDriver struct {
@@ -154,7 +152,3 @@ func (d *BaseDriver) GuestAgentConn(_ context.Context) (net.Conn, error) {
 	// use the unix socket forwarded by host agent
 	return nil, nil
 }
-
-func (d *BaseDriver) CheckBinarySignature(_ context.Context, _ string) error {
-	return errors.New("unimplemented")
-}

pkg/instance/start.go

@@ -12,7 +12,6 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
-	"runtime"
 	"syscall"
 	"text/template"
 	"time"
@@ -82,14 +81,6 @@ func Prepare(ctx context.Context, inst *store.Instance) (*Prepared, error) {
 		Instance: inst,
 	})
 
-	// Ask the user to sign the qemu binary with the "com.apple.security.hypervisor" if needed.
-	// Workaround for https://github.com/lima-vm/lima/issues/1742
-	if runtime.GOOS == "darwin" && inst.VMType == limayaml.QEMU {
-		if err := limaDriver.CheckBinarySignature(ctx, inst.Arch); err != nil {
-			return nil, err
-		}
-	}
-
 	if err := limaDriver.Validate(); err != nil {
 		return nil, err
 	}

pkg/qemu/qemu_driver.go

@@ -50,6 +50,25 @@ func New(driver *driver.BaseDriver) *LimaQemuDriver {
 }
 
 func (l *LimaQemuDriver) Validate() error {
+	// Ask the user to sign the qemu binary with the "com.apple.security.hypervisor" if needed.
+	// Workaround for https://github.com/lima-vm/lima/issues/1742
+	if runtime.GOOS == "darwin" && l.BaseDriver.Instance.VMType == limayaml.QEMU {
+		macOSProductVersion, err := osutil.ProductVersion()
+		if err != nil {
+			return err
+		}
+		// The codesign --xml option is only available on macOS Monterey and later
+		if !macOSProductVersion.LessThan(*semver.New("12.0.0")) {
+			qExe, _, err := Exe(l.BaseDriver.Instance.Arch)
+			if err != nil {
+				return fmt.Errorf("failed to find the QEMU binary for the architecture %q: %w", l.BaseDriver.Instance.Arch, err)
+			}
+			if accel := Accel(l.BaseDriver.Instance.Arch); accel == "hvf" {
+				entitlementutil.AskToSignIfNotSignedProperly(qExe)
+			}
+		}
+	}
+
 	if *l.Instance.Config.MountType == limayaml.VIRTIOFS && runtime.GOOS != "linux" {
 		return fmt.Errorf("field `mountType` must be %q or %q for QEMU driver on non-Linux, got %q",
 			limayaml.REVSSHFS, limayaml.NINEP, *l.Instance.Config.MountType)
@@ -411,25 +430,6 @@ func (l *LimaQemuDriver) GuestAgentConn(ctx context.Context) (net.Conn, error) {
 	return dialContext, err
 }
 
-func (l *LimaQemuDriver) CheckBinarySignature(_ context.Context, arch string) error {
-	macOSProductVersion, err := osutil.ProductVersion()
-	if err != nil {
-		return err
-	}
-	// The codesign --xml option is only available on macOS Monterey and later
-	if !macOSProductVersion.LessThan(*semver.New("12.0.0")) {
-		qExe, _, err := Exe(arch)
-		if err != nil {
-			return fmt.Errorf("failed to find the QEMU binary for the architecture %q: %w", arch, err)
-		}
-		if accel := Accel(arch); accel == "hvf" {
-			entitlementutil.AskToSignIfNotSignedProperly(qExe)
-		}
-	}
-
-	return nil
-}
-
 type qArgTemplateApplier struct {
 	files []*os.File
 }