You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we display an error when the user tries limactl edit on a running instance.
Instead we should display a prompt and offer the user to stop the instance first (or to abort).
The option to stop the instance should be the default selection, so using limactl edit --yes (see #3345) on a running instance would stop it, perform the edit, and then restart it.
Running limactl edit --yes --set ... should not return until the instance is running again, just as if the user had been running:
limactl stop
limactl edit --set ...
limactl start
I can't make up my mind if it would be a good idea to perform the edit operation first before stopping a running instance. That we we can validate the edit first, and skip the restarting if either the new lima.yaml doesn't validate, or if no changes have been made.
But this complicates things quite a bit, just to optimize the failure case, so maybe not worth it.
The text was updated successfully, but these errors were encountered:
I can't make up my mind if it would be a good idea to perform the edit operation first before stopping a running instance. That we we can validate the edit first, and skip the restarting if either the new lima.yaml doesn't validate, or if no changes have been made.
A possible user flow is to first edit and validate the changes, and then we can prompt the user to restart the VM(that requires #3323 ). However, I'm afraid while halting the instance during restart, is it necessary that the YAML file should not be modified(i.e. it should be in the form that the instance was launched in)?
Right now we display an error when the user tries
limactl edit
on a running instance.Instead we should display a prompt and offer the user to stop the instance first (or to abort).
The option to stop the instance should be the default selection, so using
limactl edit --yes
(see #3345) on a running instance would stop it, perform the edit, and then restart it.Running
limactl edit --yes --set ...
should not return until the instance is running again, just as if the user had been running:I can't make up my mind if it would be a good idea to perform the edit operation first before stopping a running instance. That we we can validate the edit first, and skip the restarting if either the new
lima.yaml
doesn't validate, or if no changes have been made.But this complicates things quite a bit, just to optimize the failure case, so maybe not worth it.
The text was updated successfully, but these errors were encountered: