Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integrate clang-format #104

Closed
6 tasks
nirs opened this issue Dec 6, 2024 · 2 comments · Fixed by #120
Closed
6 tasks

Integrate clang-format #104

nirs opened this issue Dec 6, 2024 · 2 comments · Fixed by #120
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/test

Comments

@nirs
Copy link
Member

nirs commented Dec 6, 2024

To keep consistent format without effort, we want to have automatic code formatting. clang-format seems to to be the best tool for this.

Taks:

  • Document clang-format developer requirement in CONTRIBUTING.md
  • Add CI auto-format check, failing if code is not formatted
  • Pick one of the builtin styles (LLVM, GNU, Google, Chromium, Microsoft, Mozilla, WebKit)
  • or add a .clang-format file to match our style
  • Find how to keep aligned text - seems that we need to skip the formatter around aligned text
  • Change the style to something more readable? 2 spaces are not great

Links:

@nirs nirs added good first issue Good for newcomers help wanted Extra attention is needed kind/test labels Dec 6, 2024
@nirs nirs mentioned this issue Dec 6, 2024
@saurabhraghuvanshii
Copy link
Contributor

can i work on this.

@jandubois
Copy link
Member

@saurabhraghuvanshii Sure, go ahead. I've assigned this issue to you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants