Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename --base to --base-url #1607

Closed
mre opened this issue Jan 6, 2025 · 0 comments · Fixed by #1629 · May be fixed by #1644
Closed

Rename --base to --base-url #1607

mre opened this issue Jan 6, 2025 · 0 comments · Fixed by #1629 · May be fixed by #1644
Labels
breaking-change good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mre
Copy link
Member

mre commented Jan 6, 2025

--base is not explicit enough about the fact that it expects a URL as an argument.
I propose to rename it to --base-url.
Related comment by @MichaIng: #1574 (comment)

Also update the docs at https://github.com/lycheeverse/lycheeverse.github.io.
@mre mre added good first issue Good for newcomers help wanted Extra attention is needed breaking-change labels Jan 6, 2025
Arteiii added a commit to Arteiii/lychee that referenced this issue Feb 10, 2025
@Arteiii
renamed base to base_url (fixes lycheeverse#1607)
d596bbb
@Arteiii Arteiii mentioned this issue Feb 10, 2025
Merged
@mre mre closed this as completed in #1629 Feb 16, 2025
@mre mre closed this as completed in d6bbf85 Feb 16, 2025
@mre mre mentioned this issue Feb 16, 2025
Closed
@mre mre mentioned this issue Feb 24, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
breaking-change good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
1 participant
@mre