Skip to content

Commit 075563f

Browse files
Merge pull request #153 from kepano/fix/copy-casing
Copywriting improvements to match official guidelines
2 parents 8fe741b + 7d95385 commit 075563f

File tree

2 files changed

+25
-30
lines changed

2 files changed

+25
-30
lines changed

src/settings/PropertyMappingModelComponent.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<pre class="media-db-plugin-property-mapping-element-property-name"><code>{property.property}</code></pre>
2525
</div>
2626
{#if property.locked}
27-
<div class="media-db-plugin-property-binding-text">property can not be remapped</div>
27+
<div class="media-db-plugin-property-binding-text">property cannot be remapped</div>
2828
{:else}
2929
<select class="dropdown" bind:value={property.mapping}>
3030
{#each propertyMappingOptions as remappingOption}

src/settings/Settings.ts

+24-29
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ export class MediaDbSettingTab extends PluginSettingTab {
179179

180180
containerEl.empty();
181181

182-
containerEl.createEl('h2', { text: 'Media DB Plugin Settings' });
183-
184182
new Setting(containerEl)
185183
.setName('OMDb API key')
186184
.setDesc('API key for "www.omdbapi.com".')
@@ -281,7 +279,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
281279
});
282280
});
283281

284-
// containerEl.createEl('h3', { text: 'APIs Per Media Type' });
282+
// containerEl.createEl('h3', { text: 'APIs per media type' });
285283
// containerEl.createEl('h5', { text: 'Movies' });
286284
// new Setting(containerEl)
287285
// .setName('OMDb API')
@@ -349,10 +347,10 @@ export class MediaDbSettingTab extends PluginSettingTab {
349347
// });
350348
// });
351349

352-
containerEl.createEl('h3', { text: 'New File Location' });
350+
new Setting(containerEl).setName('New file location').setHeading();
353351
// region new file location
354352
new Setting(containerEl)
355-
.setName('Movie Folder')
353+
.setName('Movie folder')
356354
.setDesc('Where newly imported movies should be placed.')
357355
.addSearch(cb => {
358356
new FolderSuggest(this.app, cb.inputEl);
@@ -365,7 +363,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
365363
});
366364

367365
new Setting(containerEl)
368-
.setName('Series Folder')
366+
.setName('Series folder')
369367
.setDesc('Where newly imported series should be placed.')
370368
.addSearch(cb => {
371369
new FolderSuggest(this.app, cb.inputEl);
@@ -378,7 +376,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
378376
});
379377

380378
new Setting(containerEl)
381-
.setName('Manga Folder')
379+
.setName('Manga folder')
382380
.setDesc('Where newly imported manga should be placed.')
383381
.addSearch(cb => {
384382
new FolderSuggest(this.app, cb.inputEl);
@@ -391,7 +389,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
391389
});
392390

393391
new Setting(containerEl)
394-
.setName('Game Folder')
392+
.setName('Game folder')
395393
.setDesc('Where newly imported games should be placed.')
396394
.addSearch(cb => {
397395
new FolderSuggest(this.app, cb.inputEl);
@@ -404,7 +402,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
404402
});
405403

406404
new Setting(containerEl)
407-
.setName('Wiki Folder')
405+
.setName('Wiki folder')
408406
.setDesc('Where newly imported wiki articles should be placed.')
409407
.addSearch(cb => {
410408
new FolderSuggest(this.app, cb.inputEl);
@@ -417,7 +415,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
417415
});
418416

419417
new Setting(containerEl)
420-
.setName('Music Folder')
418+
.setName('Music folder')
421419
.setDesc('Where newly imported music should be placed.')
422420
.addSearch(cb => {
423421
new FolderSuggest(this.app, cb.inputEl);
@@ -430,7 +428,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
430428
});
431429

432430
new Setting(containerEl)
433-
.setName('Board Game Folder')
431+
.setName('Board game folder')
434432
.setDesc('Where newly imported board games should be places.')
435433
.addSearch(cb => {
436434
new FolderSuggest(this.app, cb.inputEl);
@@ -442,7 +440,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
442440
});
443441
});
444442
new Setting(containerEl)
445-
.setName('Book Folder')
443+
.setName('Book folder')
446444
.setDesc('Where newly imported books should be placed.')
447445
.addSearch(cb => {
448446
new FolderSuggest(this.app, cb.inputEl);
@@ -455,7 +453,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
455453
});
456454
// endregion
457455

458-
containerEl.createEl('h3', { text: 'Template Settings' });
456+
new Setting(containerEl).setName('Template settings').setHeading();
459457
// region templates
460458
new Setting(containerEl)
461459
.setName('Movie template')
@@ -523,7 +521,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
523521
});
524522

525523
new Setting(containerEl)
526-
.setName('Music Release template')
524+
.setName('Music release template')
527525
.setDesc('Template file to be used when creating a new note for a music release.')
528526
.addSearch(cb => {
529527
new FileSuggest(this.app, cb.inputEl);
@@ -536,7 +534,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
536534
});
537535

538536
new Setting(containerEl)
539-
.setName('Board Game template')
537+
.setName('Board game template')
540538
.setDesc('Template file to be used when creating a new note for a boardgame.')
541539
.addSearch(cb => {
542540
new FileSuggest(this.app, cb.inputEl);
@@ -562,7 +560,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
562560
});
563561
// endregion
564562

565-
containerEl.createEl('h3', { text: 'File Name Settings' });
563+
new Setting(containerEl).setName('File name settings').setHeading();
566564
// region file name templates
567565
new Setting(containerEl)
568566
.setName('Movie file name template')
@@ -625,7 +623,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
625623
});
626624

627625
new Setting(containerEl)
628-
.setName('Music Release file name template')
626+
.setName('Music release file name template')
629627
.setDesc('Template for the file name used when creating a new note for a music release.')
630628
.addText(cb => {
631629
cb.setPlaceholder(`Example: ${DEFAULT_SETTINGS.musicReleaseFileNameTemplate}`)
@@ -637,7 +635,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
637635
});
638636

639637
new Setting(containerEl)
640-
.setName('Board Game file name template')
638+
.setName('Board game file name template')
641639
.setDesc('Template for the file name used when creating a new note for a boardgame.')
642640
.addText(cb => {
643641
cb.setPlaceholder(`Example: ${DEFAULT_SETTINGS.boardgameFileNameTemplate}`)
@@ -663,19 +661,16 @@ export class MediaDbSettingTab extends PluginSettingTab {
663661

664662
// region Property Mappings
665663
if (this.plugin.settings.useDefaultFrontMatter) {
666-
containerEl.createEl('h3', { text: 'Property Mappings' });
664+
new Setting(containerEl).setName('Property mappings').setHeading();
667665

668666
const propertyMappingExplanation = containerEl.createEl('div');
669667
propertyMappingExplanation.innerHTML = `
670-
<p>Allow you to remap the metadata fields of newly created media db entries.</p>
671-
<p>
672-
The different options are:
673-
<lu>
674-
<li>"default": does no remapping and keeps the metadata field as it is</li>
675-
<li>"remap": renames the metadata field to what ever you specify</li>
676-
<li>"remove": removes the metadata field entirely</li>
677-
</lu>
678-
</p>
668+
<p>Choose how metadata fields are mapped to property names. The options are:</p>
669+
<ul>
670+
<li><strong>default</strong>: keep the original name.</li>
671+
<li><strong>remap</strong>: rename the property.</li>
672+
<li><strong>remove</strong>: remove the property entirely.</li>
673+
</ul>
679674
<p>
680675
Don't forget to save your changes using the save button for each individual category.
681676
</p>`;
@@ -696,7 +691,7 @@ export class MediaDbSettingTab extends PluginSettingTab {
696691
}
697692

698693
this.plugin.settings.propertyMappingModels = propertyMappingModels;
699-
new Notice(`MDB: Property Mappings for ${model.type} saved successfully.`);
694+
new Notice(`MDB: Property mappings for ${model.type} saved successfully.`);
700695
void this.plugin.saveSettings();
701696
},
702697
},

0 commit comments

Comments
 (0)