-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
InstantMeiliSearchInstance is not assignable to type 'SearchClient | CompositionClient' #1377
Comments
Hi @flevi29, I haven't gotten time to investigate. Could this be related to the updates we performed on the generated types? |
I'm going to investigate it, but I doubt it's us, we're probably just out of date. Unless previous versions worked fine, but even then it's possible. One thing's for sure, the error message is not being very helpful. |
I'm actually not sure what's the problem here, Algolia types are such a cluster****, I've opened #1378, for now I'm leaving it. |
@Strift Okay, I've taken a look at the source code. There really isn't a |
Thanks for the investigation @flevi29. I'll see how I can prioritize this after the v1.13 release of Meilisearch. |
@flevi29 this is how i am currently using it (search() and other func are inside .client)
|
This is not only issue of the latest instantsearch. I ran into this issue with react-instantsearch 7.13.9 as well after updating to 0.24.0 |
Summary
The instantsearch client (
@meilisearch/instant-meilisearch
) typing is incompatible with the latest release ofinstantsearch
.Context
Description
The types expected by the latest versions of
react-instantsearch
and the client returned by@meilisearch/instant-meilisearch
andmeilisearch
do not match.Versions used:
Current behavior
Since the new update of the library, a type error occurs when passing the search client returned by
instant-meilisearch
to the InstantSearch component.(The
searchClient
prop expects aSearchClient | CompositionClient
type)Expected behavior
No error should occur.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: