Skip to content

Do we need structs in plan::tracing and ProcessedgesWork to be public? #950

Open
@qinsoon

Description

@qinsoon

I noticed these API changes reported in #897. The changed items are exposed as public. But it is probably unnecessary to make them public. We should consider making them private.

Changed items in the public API
===============================
-pub fn mmtk::plan::ObjectsClosure<'a, E>::new(worker: &'a mut mmtk::scheduler::GCWorker<<E as mmtk::scheduler::ProcessEdgesWork>::VM>) -> Self
+pub fn mmtk::plan::ObjectsClosure<'a, E>::new(worker: &'a mut mmtk::scheduler::GCWorker<<E as mmtk::scheduler::ProcessEdgesWork>::VM>, bucket: mmtk::scheduler::WorkBucketStage) -> Self
...
-pub fn mmtk::scheduler::ProcessEdgesWork::new(edges: alloc::vec::Vec<<<Self as mmtk::scheduler::ProcessEdgesWork>::VM as mmtk::vm::VMBinding>::VMEdge>, roots: bool, mmtk: &'static mmtk::MMTK<Self::VM>) -> Self
+pub fn mmtk::scheduler::ProcessEdgesWork::new(edges: alloc::vec::Vec<<<Self as mmtk::scheduler::ProcessEdgesWork>::VM as mmtk::vm::VMBinding>::VMEdge>, roots: bool, mmtk: &'static mmtk::MMTK<Self::VM>, bucket: mmtk::scheduler::WorkBucketStage) -> Self

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-interfaceArea: Interface/APIF-questionCall For Participation: Unanswered question (need more information)P-normalPriority: Normal.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions