From ae271247b59fb0e30126700d7fb4a2dac26e9383 Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Tue, 15 Apr 2025 09:49:10 -0400 Subject: [PATCH 1/2] ci: remove leftover DEBUG env vars --- .github/workflows/e2e-tests.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index d92d8da868f..b322f07b2e4 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -17,8 +17,6 @@ jobs: name: E2E Windows tests runs-on: ${{ matrix.os }} timeout-minutes: 20 - env: - DEBUG: true strategy: matrix: os: [windows-latest] @@ -72,8 +70,6 @@ jobs: name: E2E runs-on: ${{ matrix.os }} timeout-minutes: 10 - env: - DEBUG: true strategy: matrix: os: [ubuntu-latest, macOS-latest] From c0550aadd595a3af5825185603d9cc7f93e41f28 Mon Sep 17 00:00:00 2001 From: Philippe Serhal Date: Tue, 15 Apr 2025 09:49:43 -0400 Subject: [PATCH 2/2] ci(e2e): add same Windows perf config as for integration tests We have this in the integration test setup, and e2e tests are excruciatingly slow on Windows (4-7 mins PER TEST), so let's give this a try. --- .github/workflows/e2e-tests.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index b322f07b2e4..2e42c6aad99 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -24,6 +24,12 @@ jobs: node-version: ['18.14.0', '20.12.2', '22'] fail-fast: false steps: + # This improves Windows network performance. We need this since we open many ports in our tests. + - name: Increase Windows port limit and reduce time wait delay + run: | + netsh int ipv4 set dynamicport tcp start=1025 num=64511 + REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\TCPIP\Parameters /v TcpTimedWaitDelay /t REG_DWORD /d 30 /f + - name: Git checkout uses: actions/checkout@v4 with: