Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

OGGM features vs independent calculations #5

Open
nmaffe opened this issue Aug 5, 2024 · 2 comments
Open

OGGM features vs independent calculations #5

nmaffe opened this issue Aug 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@nmaffe
Copy link
Owner

nmaffe commented Aug 5, 2024

zmin, zmax, zmed are currently imported from oggm. I think using tandemx could be better ?
@nmaffe nmaffe added this to iceboost Aug 5, 2024
@nmaffe nmaffe added the enhancement New feature or request label Aug 5, 2024
@nmaffe nmaffe moved this to Todo in iceboost Aug 5, 2024
@nmaffe
Copy link
Owner Author

nmaffe commented Aug 23, 2024

Also points_df['Slope'] = gl_df['Slope'].item() should be replaced.

At training time one idea is to clip slope xarray with geometry and calculate mean slope.
At inference time one idea is to calculate the mean of the interpolated slope values.

@nmaffe nmaffe changed the title zmin, zmax, zmed OGGM features vs independent calculations Aug 23, 2024
@nmaffe
Copy link
Owner Author

nmaffe commented Aug 23, 2024

replace OGGM's Lmax with lmax_with_covex_hull both at training time and inference time

@nmaffe nmaffe moved this from Todo to In Progress in iceboost Oct 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
iceboost
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nmaffe