Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Validate evaluate_files() arguments #117

Closed
jeremyfowers opened this issue Feb 21, 2024 · 0 comments
Closed

Validate evaluate_files() arguments #117

jeremyfowers opened this issue Feb 21, 2024 · 0 comments
Labels
bug Something isn't working p2 Low priority

Comments

@jeremyfowers
Copy link
Collaborator

Problem: the benchmark_files() API expects a List[str] as input to its input_files argument. However, if you pass it a string, it treats that string like a list of characters and throws this exception:

Error: ['h', 'o', 'm', 'e', 'a', 'z', 'u', 'r', 'e', 'u', 's', 'e', 'r', 't', 'u', 'r', 'n', 'k', 'e', 'y', 'm', 'l', 'm', 'o', 'd', 'e', 'l', 's', 't', 'r', 'a', 'n', 's', 'f', 'o', 'r', 'm', 'e', 'r', 's', 'g', 'p', 't', 'j', 'p', 'y'] do not exist, please verify if the file(s) exists.

▄██████████████▄▐█▄▄▄▄█▌
██████▌▄▌▄▐▐▌███▌▀▀██▀▀
████▄█▌▄▌▄▐▐▌▀███▄▄█▌
▄▄▄▄▄██████████████

Solution: validate that benchmark_files() arguments are of the expected type.

cc @danielholanda @ramkrishna2910

@jeremyfowers jeremyfowers added bug Something isn't working p2 Low priority labels Feb 21, 2024
@jeremyfowers jeremyfowers added this to the Data Quality milestone Feb 21, 2024
@jeremyfowers jeremyfowers removed this from the Data Quality milestone Mar 22, 2024
@jeremyfowers jeremyfowers changed the title Validate benchmark_files() arguments Validate evaluate_files() arguments Jul 22, 2024
@jeremyfowers jeremyfowers closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working p2 Low priority
Projects
None yet
Development

No branches or pull requests

1 participant