fix: Attempt to save ParseObject even if its nested ParseObject failed to save (#859)

Author: Nidal-Bakir

packages/dart/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [4.0.2](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-4.0.1...dart-4.0.2) (2023-03-23)
+
+### Bug Fixes
+
+* Attempt to save `ParseObject` even if its nested `ParseObject` failed to save ([#859](https://github.com/parse-community/Parse-SDK-Flutter/pull/859))
+
 ## [4.0.1](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-4.0.0...dart-4.0.1) (2023-03-20)
 
 ### Bug Fixes

packages/dart/lib/src/base/parse_constants.dart

@@ -1,7 +1,7 @@
 part of flutter_parse_sdk;
 
 // Library
-const String keySdkVersion = '4.0.1';
+const String keySdkVersion = '4.0.2';
 const String keyLibraryName = 'Flutter Parse SDK';
 
 // End Points

packages/dart/lib/src/objects/parse_object.dart

@@ -138,34 +138,42 @@ class ParseObject extends ParseBase implements ParseCloneable {
       final ParseResponse response = ParseResponse();
       return response;
     }
+
     if (object is ParseObject) {
       uniqueObjects.remove(object);
     }
+
     for (ParseFileBase file in uniqueFiles) {
       final ParseResponse response = await file.save();
       if (!response.success) {
         return response;
       }
     }
+
     List<ParseObject> remaining = uniqueObjects.toList();
     final List<ParseObject> finished = <ParseObject>[];
+
     final ParseResponse totalResponse = ParseResponse()
       ..success = true
       ..results = <dynamic>[]
       ..statusCode = 200;
+
     while (remaining.isNotEmpty) {
       /* Partition the objects into two sets: those that can be save immediately,
       and those that rely on other objects to be created first. */
       final List<ParseObject> current = <ParseObject>[];
       final List<ParseObject> nextBatch = <ParseObject>[];
+
       for (ParseObject object in remaining) {
         if (object._canbeSerialized(finished)) {
           current.add(object);
         } else {
           nextBatch.add(object);
         }
       }
+
       remaining = nextBatch;
+
       // TODO(yulingtianxia): lazy User
       /* Batch requests have currently a limit of 50 packaged requests per single request
       This splitting will split the overall array into segments of upto 50 requests
@@ -179,6 +187,7 @@ class ParseObject extends ParseBase implements ParseCloneable {
         final List<dynamic> requests = chunk.map<dynamic>((ParseObject obj) {
           return obj._getRequestJson(obj.objectId == null ? 'POST' : 'PUT');
         }).toList();
+
         for (ParseObject obj in chunk) {
           obj._saveChanges();
         }
@@ -188,13 +197,19 @@ class ParseObject extends ParseBase implements ParseCloneable {
           client: _client,
         );
         totalResponse.success &= response.success;
+
         if (response.success) {
           totalResponse.results!.addAll(response.results!);
           totalResponse.count += response.count;
+
           for (int i = 0; i < response.count; i++) {
             if (response.results![i] is ParseError) {
               // Batch request succeed, but part of batch failed.
               chunk[i]._revertSavingChanges();
+
+              // if any request in a batch requests group fails,
+              // then the overall response will be considered unsuccessful.
+              totalResponse.success = false;
             } else {
               chunk[i]._savingChanges.clear();
             }
@@ -204,12 +219,15 @@ class ParseObject extends ParseBase implements ParseCloneable {
           for (ParseObject obj in chunk) {
             obj._revertSavingChanges();
           }
+
           totalResponse.statusCode = response.statusCode;
           totalResponse.error = response.error;
         }
       }
+
       finished.addAll(current);
     }
+
     return totalResponse;
   }
 

packages/dart/pubspec.yaml

@@ -1,6 +1,6 @@
 name: parse_server_sdk
 description: Dart plugin for Parse Server, (https://parseplatform.org), (https://back4app.com)
-version: 4.0.1
+version: 4.0.2
 homepage: https://github.com/parse-community/Parse-SDK-Flutter
 
 environment:

packages/dart/test/src/objects/parse_object/parse_object_save_test.dart

@@ -481,7 +481,6 @@ void main() {
 
         verifyNoMoreInteractions(client);
       },
-      skip: 'see #853 and #854',
     );
   });
 }