Skip to content

https なサイトでプルリクの内容をプレビューしたい #24

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
odanado opened this issue Feb 11, 2020 · 2 comments
Closed

https なサイトでプルリクの内容をプレビューしたい #24

odanado opened this issue Feb 11, 2020 · 2 comments

Comments

@odanado
Copy link
Contributor

odanado commented Feb 11, 2020

#2 対応のように事前に https なサイトで動作確認をしたい場合がある
また、レビューを行うときの動作確認で、プレビューサイトがあると便利

Netlify には Deploy Preview 機能があり、プルリク単位でプレビューが可能
https://www.netlify.com/blog/2016/07/20/introducing-deploy-previews-in-netlify/
GitHub Actions で静的ファイルを build → Netlify でシュッとプレビューサイトを用意したい
@odanado
Copy link
Contributor Author

odanado commented Mar 23, 2020

ここで試しています
odanado#1
とりあえず、動いています(なぜコメントが複数個ついているけど...)

@odanado odanado mentioned this issue May 7, 2020
Merged
@kfly8 kfly8 mentioned this issue May 7, 2020
Closed
@kfly8 kfly8 linked a pull request May 7, 2020 that will close this issue
Netlify の draft プレビュー機能の確認 #27
Closed
@kfly8
Copy link
Contributor

kfly8 commented Jun 21, 2020

解決済みなのでクローズします。

@kfly8 kfly8 closed this as completed Jun 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Netlify の draft プレビュー機能の確認 perl-users-jp/perl-users-jp.github.io
2 participants
@kfly8 @odanado