Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Redis redelivery_delay setting does not work #1342

Open
compwright opened this issue Mar 18, 2024 · 0 comments · May be fixed by #1343
Open

Redis redelivery_delay setting does not work #1342

compwright opened this issue Mar 18, 2024 · 0 comments · May be fixed by #1343

Comments

@compwright
Copy link

Redis messages are delivered immediately, back-to-back, not respecting either the default redelivery_delay setting (300) or a custom setting.
compwright added a commit to compwright/enqueue-dev that referenced this issue Mar 18, 2024
@compwright
fix: redis redelivery_delay setting does not work
68dcc77 
When using the redis transport, RedisConsumer::processResult() creates the redelivered record prior to the RedisSubscription callback executing. The subscription callback attached with Enqueue\Consumption\QueueConsumer then invokes RedisConsumer::reject(). Calling acknowledge() deletes the redelivered record which was created earlier. Thus, we should not create a new record in reject() and we should only call acknowledge() if we do not wish to redeliver. I have tested and confirmed that this change fixes the issue. However, if there is a better solution, please advise.

Resolves php-enqueue#1342
@compwright compwright linked a pull request Mar 18, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redis redelivery_delay setting does not work compwright/enqueue-dev
1 participant
@compwright