Skip to content

Commit fd03f9d

Browse files
committedJan 15, 2025
Removing constructor tests
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
1 parent cf01068 commit fd03f9d

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed
 

Diff for: ‎Tests/JsonSerializerTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@ public function testShouldImplementSerializerInterface()
1717
$this->assertClassImplements(Serializer::class, JsonSerializer::class);
1818
}
1919

20-
/**
21-
* @doesNotPerformAssertions
22-
*/
23-
public function testCouldBeConstructedWithoutAnyArguments()
24-
{
25-
new JsonSerializer();
26-
}
27-
2820
public function testShouldConvertMessageToJsonString()
2921
{
3022
$serializer = new JsonSerializer();

Diff for: ‎Tests/RdKafkaConsumerTest.php

-13
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,6 @@
1313

1414
class RdKafkaConsumerTest extends TestCase
1515
{
16-
/**
17-
* @doesNotPerformAssertions
18-
*/
19-
public function testCouldBeConstructedWithRequiredArguments()
20-
{
21-
new RdKafkaConsumer(
22-
$this->createKafkaConsumerMock(),
23-
$this->createContextMock(),
24-
new RdKafkaTopic(''),
25-
$this->createSerializerMock()
26-
);
27-
}
28-
2916
public function testShouldReturnQueueSetInConstructor()
3017
{
3118
$destination = new RdKafkaTopic('');

Diff for: ‎Tests/RdKafkaProducerTest.php

-8
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@
1717

1818
class RdKafkaProducerTest extends TestCase
1919
{
20-
/**
21-
* @doesNotPerformAssertions
22-
*/
23-
public function testCouldBeConstructedWithKafkaProducerAndSerializerAsArguments()
24-
{
25-
new RdKafkaProducer($this->createKafkaProducerMock(), $this->createSerializerMock());
26-
}
27-
2820
public function testThrowIfDestinationInvalid()
2921
{
3022
$producer = new RdKafkaProducer($this->createKafkaProducerMock(), $this->createSerializerMock());

0 commit comments

Comments
 (0)