Skip to content

s-maxage Cache-Control directive is ignored #47

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
xabbuh opened this issue Dec 18, 2017 · 1 comment
Open

s-maxage Cache-Control directive is ignored #47

xabbuh opened this issue Dec 18, 2017 · 1 comment
Milestone

Comments

@xabbuh
Copy link
Member

xabbuh commented Dec 18, 2017

Q A
Bug? yes
New Feature? no
Version all

Actual Behavior

When you are initialising the CachePlugin in server mode (using CachePlugin::serverCache, for example), the s-maxage directive of the Cache-Control header is never taken into account which means that cacheable responses are always cached with the default TTL.

Expected Behavior

The s-maxage directive is used as the TTL for cached responses.

Steps to Reproduce

Send requests to an endpoint where the shared max age directive's value of the Cache-Control header is different than the default TTL. Cache entries will expire after the default TTL.

@dbu
Copy link
Contributor

dbu commented Dec 18, 2017

i guess that would indeed make sense. in server mode, the plugin does manage a shared cache so s-maxage seems reasonable.

@dbu dbu added this to the 3.0 milestone Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants