Skip to content

Resolve TODO: re-check options route in fractal action #35

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
SOHELAHMED7 opened this issue Aug 28, 2024 · 0 comments · Fixed by #36
Closed

Resolve TODO: re-check options route in fractal action #35

SOHELAHMED7 opened this issue Aug 28, 2024 · 0 comments · Fixed by #36
Assignees

Comments

@SOHELAHMED7
Copy link
Member

Resolve below TODO:

File: src/lib/items/FractalAction.php::getOptionsRoute()

public function getOptionsRoute():string
    {
        //@TODO: re-check
        if ($this->prefix && !empty($this->prefixSettings)) {
            $prefix = $this->prefixSettings['module'] ?? $this->prefix;
            return trim($prefix, '/').'/'.$this->controllerId.'/options';
        }
        return $this->controllerId.'/options';
    }

Part of #10

and

Part of cebe#180

@SOHELAHMED7 SOHELAHMED7 self-assigned this Aug 28, 2024
@SOHELAHMED7 SOHELAHMED7 linked a pull request Aug 28, 2024 that will close this issue
@cebe cebe closed this as completed in #36 Dec 11, 2024
cebe added a commit that referenced this issue Dec 11, 2024
…ons-route-in-fractal-action

Resolve TODO: re-check options route in fractal action #35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant