Skip to content

Commit 17f123f

Browse files
committed
fix: added pgpro_stats temporary dirty hack
1 parent fc2c875 commit 17f123f

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

Diff for: mamonsu/plugins/pgsql/statements.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,7 @@ def run(self, zbx):
131131
columns = [x[1] for x in all_items]
132132
elif Pooler.server_version_greater("13"):
133133
self.Items[5][1] = self.Items[5][1].format("total_exec_time+total_plan_time")
134-
if not Pooler.is_pgpro() or not Pooler.is_pgpro_ee():
135-
all_items += self.Items_pg_13
134+
all_items += self.Items_pg_13
136135
columns = [x[1] for x in all_items]
137136
else:
138137
self.Items[5][1] = self.Items[5][1].format("total_time")

Diff for: mamonsu/tools/bootstrap/sql.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@
292292
json_data.value::int AS count
293293
FROM (SELECT key, value AS locktuple
294294
FROM jsonb_each((SELECT wait_stats
295-
FROM ' || extension_schema || '.pgpro_stats_totals
295+
FROM ' || extension_schema || '.pgpro_stats_totals()
296296
WHERE object_type = ''cluster''))) setoflocks,
297297
jsonb_each(setoflocks.locktuple) AS json_data)
298298
SELECT
@@ -321,7 +321,7 @@
321321
json_data.value::int AS count
322322
FROM (SELECT key, value AS locktuple
323323
FROM jsonb_each((SELECT wait_stats
324-
FROM ' || extension_schema || '.pgpro_stats_totals
324+
FROM ' || extension_schema || '.pgpro_stats_totals()
325325
WHERE object_type = ''cluster''))) setoflocks,
326326
jsonb_each(setoflocks.locktuple) AS json_data)
327327
SELECT
@@ -341,7 +341,7 @@
341341
json_data.value::int AS count
342342
FROM (SELECT key, value AS locktuple
343343
FROM jsonb_each((SELECT wait_stats
344-
FROM ' || extension_schema || '.pgpro_stats_totals
344+
FROM ' || extension_schema || '.pgpro_stats_totals()
345345
WHERE object_type = ''cluster''))) setoflocks,
346346
jsonb_each(setoflocks.locktuple) AS json_data
347347
WHERE setoflocks.key IN (''Lock'', ''LWLock'', ''LWLockTranche'', ''LWLockNamed''))
@@ -415,7 +415,7 @@
415415
CREATE OR REPLACE FUNCTION mamonsu.statements_pro()
416416
RETURNS TABLE({columns}) AS $$
417417
SELECT {metrics}
418-
FROM ' || extension_schema || '.pgpro_stats_totals
418+
FROM ' || extension_schema || '.pgpro_stats_totals()
419419
WHERE object_type = ''cluster'';
420420
$$ LANGUAGE SQL SECURITY DEFINER;';
421421
ELSE

Diff for: mamonsu/tools/bootstrap/start.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,13 @@ def run_deploy():
237237
if Pooler.is_pgpro() or Pooler.is_pgpro_ee():
238238
bootstrap_extension_queries = fill_query_params(CreateWaitSamplingFunctionsSQL)
239239
Pooler.query(bootstrap_extension_queries)
240-
statements_items = [x[1] for x in Statements.Items]
241-
statements_items[5] = statements_items[5].format("total_exec_time+total_plan_time")
242-
statements_columns = [x[0][x[0].find("[")+1:x[0].find("]")] for x in Statements.Items]
243-
bootstrap_extension_queries = CreateStatementsFunctionsSQL.format(
244-
columns=" bigint, ".join(statements_columns) + " bigint", metrics=(", ".join(statements_items)))
245-
Pooler.query(bootstrap_extension_queries)
240+
if Pooler.server_version_greater("12"):
241+
statements_items = [x[1] for x in Statements.Items] + ([x[1] for x in Statements.Items_pg_13] if Pooler.server_version_greater("13") else [])
242+
statements_items[5] = statements_items[5].format("total_exec_time+total_plan_time")
243+
statements_columns = [x[0][x[0].find("[")+1:x[0].find("]")] for x in Statements.Items] + ([x[0][x[0].find("[")+1:x[0].find("]")] for x in Statements.Items_pg_13] if Pooler.server_version_greater("13") else [])
244+
bootstrap_extension_queries = CreateStatementsFunctionsSQL.format(
245+
columns=" bigint, ".join(statements_columns) + " bigint", metrics=(", ".join(statements_items)))
246+
Pooler.query(bootstrap_extension_queries)
246247
except Exception as e:
247248
sys.stderr.write(
248249
"Bootstrap failed to create auxiliary extensions and functions.\n"

0 commit comments

Comments
 (0)