Skip to content

Format the code with pgindent #72

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

vitcpp
Copy link
Contributor

@vitcpp vitcpp commented Sep 28, 2023

No description provided.

@vitcpp vitcpp linked an issue Sep 28, 2023 that may be closed by this pull request
@esabol
Copy link
Contributor

esabol commented Sep 28, 2023

I don't really like pgindent's excessive whitespace, but I'm ok with it if this is something you want.

@vitcpp
Copy link
Contributor Author

vitcpp commented Sep 28, 2023

@esabol I would suggest to consider this PR as a proposal, not a solution to be applied unconditionally. I agree with you about excessive indentation and I'm not a fan pgindent. Furthermore, the formatting of some mathematical expressions should be untouched. But I do not know another solution that may help us with the indentation. We may use pgindent as a code formatting verification tool. We will be able to automate this process. Anyway, I'm ok if we decide to reject this PR and do not use pgindent.

@esabol
Copy link
Contributor

esabol commented Sep 28, 2023

I think it’s up to you. I don’t have a strong opinion on it.

@vitcpp
Copy link
Contributor Author

vitcpp commented Oct 4, 2023

I think it would be better to limit the pgindent functionality somehow. I would propose to fix only identations at the beginnings of the strings, and function signatures. The formatting of formulae should be untouched.

@vitcpp
Copy link
Contributor Author

vitcpp commented Nov 7, 2023

Rejected, because it is outdated.

@vitcpp vitcpp closed this Nov 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgindent the code
2 participants