Skip to content

Parameterized tests relying on getWasmEngines() are not getting instantiated #412

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
mpwarres opened this issue Aug 19, 2024 · 0 comments
Assignees

Comments

@mpwarres
Copy link
Contributor

Parameterized tests that rely on getWasmEngines() to determine test cases are not actually being instantiated.

I discovered this when I updated googletest to a more recent version that detects uninstantiated parameterized tests, as part of #411.

I believe this is because getWasmEngines() looks for the presence of macro definitions such as PROXY_WASM_HOST_ENGINE_V8 as indication to include that engine in the list to return; however, those preprocessor definitions are only set in the build rules for the libraries for those engines (for example, :v8_lib, and are not visible in the compilation of test/utility.cc.

@martijneken @PiotrSikora FYI

mpwarres added a commit to mpwarres/proxy-wasm-cpp-host that referenced this issue Aug 19, 2024
Signed-off-by: Michael Warres <mpw@google.com>
@mpwarres mpwarres self-assigned this Aug 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant